i'm stumped, script help

Gravis2k · #1 09-06-2003, 10:52 AM

i made a bird transformation for my server, and i have made all of the ganis (walk,idle,attack etc...) and for some reason the walk one doesnt show on me... for an hour it would show on other people, but now it doesn't. i don't see anything wrong with the script what so ever.. if some1 could point it out i would really appreciate it.

//#CLIENTSIDE
if (weaponfired&&this.on=0) {
setani birdtransform,;
replaceani idle,birdidle;
replaceani sword,birdattack2;
replaceani walk,birdidle;
this.on=1;
}else if (weaponfired&&this.on=1) {
setani birdreform1,;
replaceani idle,idle;
replaceani sword,sword;
replaceani walk,walk;
this.on=0;
}
if(playerchats&&strequals(#c,land)){
setplayerprop #c,:

escends slowly::;
setani birdland,;
disabledefmovement;
}
if(playerchats&&strequals(#c,fly)){
setplayerprop #c,::Rises rapidly into the air::;
setani birdfly1,;
enabledefmovement;
}

Kaimetsu · #2 09-06-2003, 11:14 AM

replaceani walk,birdidle;

Gravis2k · #3 09-06-2003, 11:21 AM

i know it says birdidle, they both are the same gani for flying and idling so i only made the idle. it worked for a little bit on other people and now it doesnt work at all

Kaimetsu · #4 09-06-2003, 03:47 PM

Fair enough. Fix it up in accordance with KSI-GS and I'll try to help you in other ways.

Gravis2k · #5 09-06-2003, 08:13 PM

//#CLIENTSIDE

if (weaponfired&&this.on=0) {
setani birdtransform,;
replaceani idle,birdidle;
replaceani sword,birdattack2;
replaceani walk,birdidle;
this.on=1;
}

else if (weaponfired&&this.on=1) {
setani birdreform1,;
replaceani idle,idle;
replaceani sword,sword;
replaceani walk,walk;
this.on=0;
}

if (playerchats&&strequals(#c,land)){
setplayerprop #c,:escends slowly::;
setani birdland,;
disabledefmovement;
}

if (playerchats&&strequals(#c,fly)){
setplayerprop #c,::Rises rapidly into the air::;
setani birdfly1,;
enabledefmovement;
}

------------------------------------------------------------------
if there is anything wrong with the format tell me and i will fix it

Tseng · #6 09-06-2003, 08:16 PM

Regarding conforming to KSI-GS:

You have two successive checks of the same event. :-\

Rather than doing:

NPC Code:



if (event1 && condition1) {

  dostuff();

}

if (event1 && condition2) {

  dootherstuff();

}

Do:

NPC Code:



if (event1) {

  if (condition1) {

    dostuff();

  }

  else if (condition2) {

    dootherstuff();

  }

}

Also, you are using one equals sign for comparisons - bad!

Gravis2k · #7 09-06-2003, 08:25 PM

//#CLIENTSIDE

if (weaponfired){
if (this.on==0) {
setani birdtransform,;
replaceani idle,birdidle;
replaceani sword,birdattack2;
replaceani walk,birdidle;
this.on=1;
}
else if (this.on==1){
setani birdreform1,;
replaceani idle,idle;
replaceani sword,sword;
replaceani walk,walk;
this.on=0;
}
}

if (playerchats&&strequals(#c,land)){
setplayerprop #c,:escends slowly::;
setani birdland,;
disabledefmovement;
}

if (playerchats&&strequals(#c,fly)){
setplayerprop #c,::Rises rapidly into the air::;
setani birdfly1,;
enabledefmovement;
}

Tseng · #8 09-06-2003, 08:33 PM

Now apply the same idea to the second block, and then test the script out again.

Python523 · #9 09-06-2003, 08:35 PM

use [code] tags on the forums

Gravis2k · #10 09-06-2003, 08:50 PM

i tried, it still doesn't work.

NPC Code:



//#CLIENTSIDE 



if (weaponfired){

  if (this.on==0) { 

    setani birdtransform,; 

    replaceani idle,birdidle; 

    replaceani sword,birdattack2; 

    replaceani walk,birdidle; 

    this.on=1;

  }   

  else if (this.on==1){

    setani birdreform1,; 

    replaceani idle,idle; 

    replaceani sword,sword; 

    replaceani walk,walk; 

    this.on=0; 

  }

} 





if(playerchats&&strequals(#c,land)){

    setplayerprop #c,:escends slowly::;

    setani birdland,;

    disabledefmovement;

}

if(playerchats&&strequals(#c,fly)){

    setplayerprop #c,::Rises rapidly into the air::;

    setani birdfly1,;

    enabledefmovement;

}

Gravis2k · #11 09-06-2003, 09:31 PM

am i being ignored now lol??

Tseng · #12 09-06-2003, 10:21 PM

Quote:

Originally posted by Gravis2k
am i being ignored now lol??

You didn't listen to my last set of helping directions.

Gravis2k · #13 09-06-2003, 10:53 PM

ok done (sorry)

NPC Code:

//#CLIENTSIDE 



if (weaponfired){

  if (this.on==0) { 

    setani birdtransform,; 

    replaceani idle,birdidle; 

    replaceani sword,birdattack2; 

    replaceani walk,birdidle; 

    this.on=1;

  }   

  else if (this.on==1){

    setani birdreform1,; 

    replaceani idle,idle; 

    replaceani sword,sword; 

    replaceani walk,walk; 

    this.on=0; 

  }

} 





if (playerchats){

  if (strequals(#c,land)){

    setplayerprop #c,escends slowly::;

    setani birdland,;

    disabledefmovement;

  }





  else if (strequals(#c,fly)){

    setplayerprop #c,::Rises rapidly into the air::;

    setani birdfly1,;

    enabledefmovement;

  }

}

but that's not where my problem was.... when i am in bird form and i try to move i switch back to looking human again, my friend zach can use it and fly and still look like a bird but i can't, i can also see him flying. please help lol

everything but the walk one works. fly,land,idle, and attack all work fine.

mhermher · #14 09-06-2003, 11:54 PM

You probablly got some NPC using a loop to replaceani walk,walk; or so

Python523 · #15 09-07-2003, 12:01 AM

Quote:

Originally posted by mhermher
You probablly got some NPC using a loop to replaceani walk,walk; or so

What? You do not loops replaceani's, I thought you were a scripter

Neoreno · #16 09-07-2003, 12:04 AM

Tyrial is a graphics guy. I've never actually seen him do much scripts work.

DustyPorViva · #17 09-07-2003, 12:05 AM

I think he means there is probably some other NPCW overriding his weapons replaceani.

Gravis2k · #18 09-07-2003, 12:09 AM

huh? lol i dont have any looped replaceani's

mhermher · #19 09-07-2003, 12:31 AM

Quote:

Originally posted by Python523

What? You do not loops replaceani's, I thought you were a scripter

i were.. heh.. but i got lazy so i stopped scipting.. i do gfx now..

anyways, what i meant was that he prolly had a replaceani walk,walk; or walk,somethingwalk; or so in a timeout.. because i...

wait, just figured out.. do your gani have the "continious=true" variable on the gani?

Gravis2k · #20 09-07-2003, 12:39 AM

loop=true
continious=false

i changed it to true and i still have the same problem

Gravis2k · #21 09-07-2003, 12:46 AM

i also tried simplifiing the part that is not working to see if my variables were not working right

NPC Code:

//#CLIENTSIDE

if (weaponfired){

  replaceani idle,birdidle;

  replaceani sword,birdattack2;

  replaceani walk,birdidle;

}

but the walk gani fails on this also

Knuckles · #22 09-07-2003, 02:18 AM

Quote:

Originally posted by Gravis2k
i also tried simplifiing the part that is not working to see if my variables were not working right

NPC Code:
//#CLIENTSIDE
if (weaponfired){
replaceani idle,birdidle;
replaceani sword,birdattack2;
replaceani walk,birdidle;
}

but the walk gani fails on this also

...Try the other script offline. If it still doesnt work, then tell us, and we'll help you debug it. Else, if it does work.. then ON your server, there is another NPC (probibly a weapon) with a timeout loop, using replaceani for the walk...

So check that out too.

Kaimetsu · #23 09-07-2003, 04:43 AM

What is actually shown when the player is moving? Nothing? The default gani?

Gravis2k · #24 09-07-2003, 05:05 AM

It works now, and i feel really stupid..... it was from a script i wrote a long time ago and i had in two spots where it would replace the ani and it kept looping, i fixed it and now all of the scripts work ty for the help

(also learned something new....how to make my scripts more presentable and easy to read)