Warping players (Bug?)

[Emera]

I don't know if this is a bug or if I'm doing this wrong, but it worked a few weeks ago using this method and it's not working now. I'm basically trying to "summon" a player by sending my level, x and y to the serverside, then warping the player to the said co-ordinates. For some reason, if I'm on a gmap, it will warp the player far to the right of my co-ordinates.

This is the summon trigger.

PHP Code:

case "summon":
  with(findplayer(params[1])) {
    temp.slevel = params[2];
    temp.sx = params[3];
    temp.sy = params[4];        
    player.setlevel2(temp.slevel,temp.sx,temp.sy);
  }
break; 


and this is what I'm sending to the server.

PHP Code:

triggerserver("gui",name,"summon",wc_TextList1.selected.text,player.level,player.x,player.y); 


wc_TextList1.selected.text being a players account name.

Any ideas?

[ffcmike]

Originally Posted by Emera

I don't know if this is a bug or if I'm doing this wrong, but it worked a few weeks ago using this method and it's not working now. I'm basically trying to "summon" a player by sending my level, x and y to the serverside, then warping the player to the said co-ordinates. For some reason, if I'm on a gmap, it will warp the player far to the right of my co-ordinates.

This is the summon trigger.

PHP Code:

case "summon":
  with(findplayer(params[1])) {
    temp.slevel = params[2];
    temp.sx = params[3];
    temp.sy = params[4];        
    player.setlevel2(temp.slevel,temp.sx,temp.sy);
  }
break; 


and this is what I'm sending to the server.

PHP Code:

triggerserver("gui",name,"summon",wc_TextList1.selected.text,player.level,player.x,player.y); 


wc_TextList1.selected.text being a players account name.

Any ideas?

It's because clientside player.level is the singular level, whereas serverside player.level would be the map object, while player.x and player.y is relevant to your map coordinates.
You don't really need to be passing level and coordinates for a basic summon though, you could just do:

PHP Code:

case "summon":
  temp.pl = findplayer(params[1]);
  if(temp.pl == NULL){
    return;
  }
  temp.pl.setlevel2(player.level.name, player.x, player.y);
break; 


[Emera]

Originally Posted by ffcmike

It's because clientside player.level is the singular level, whereas serverside player.level would be the map object, while player.x and player.y is relevant to your map coordinates.
You don't really need to be passing level and coordinates for a basic summon though, you could just do:

PHP Code:

case "summon":
  temp.pl = findplayer(params[1]);
  if(temp.pl == NULL){
    return;
  }
  temp.pl.setlevel2(player.level.name, player.x, player.y);
break; 


Thank you so much <3

[scriptless]

I don't think you need "player.setlevel2".. Shouldn't that be "setlevel2()" since you already focused on the player?

[Emera]

Originally Posted by scriptless

I don't think you need "player.setlevel2".. Shouldn't that be "setlevel2()" since you already focused on the player?

It's not needed but I think it's good practice.

[scriptless]

Originally Posted by Emera

It's not needed but I think it's good practice.

Why? My mind is going "player.player.blah"... lol

[cbk1994]

Originally Posted by scriptless

Why? My mind is going "player.player.blah"... lol

Because it makes it clear what object is being acted upon.

You don't have to use player.level in a script—you could just use level. But then it's not clear what level you're working with. The NPC's level or the player's level?

It just makes it easier to understand.

[scriptless]

Originally Posted by cbk1994

Because it makes it clear what object is being acted upon.

You don't have to use player.level in a script—you could just use level. But then it's not clear what level you're working with. The NPC's level or the player's level?

It just makes it easier to understand.

So it's just for a person reading it to look easier? why not //player after it? Just curious is there any advantages?

[fowlplay4]

Originally Posted by scriptless

So it's just for a person reading it to look easier? why not //player after it? Just curious is there any advantages?

'level' on it's own could refer to this.level (NPC) or player.level depending on where the code is.

You can eliminate that possible confusion by using the appropriate prefix in your code.

Also comments are supposed to help people understand what's going on in your code not help add confusion with an obscure looking comment.

The only time I don't use the player prefix is with client and clientr flags.

[scriptless]

Originally Posted by fowlplay4

'level' on it's own could refer to this.level (NPC) or player.level depending on where the code is.

You can eliminate that possible confusion by using the appropriate prefix in your code.

Also comments are supposed to help people understand what's going on in your code not help add confusion with an obscure looking comment.

The only time I don't use the player prefix is with client and clientr flags.

Why not for client/clientr ?

[Skyld]

Originally Posted by scriptless

Why not for client/clientr ?

I personally encourage player.clientr.foo.

[Emera]

Originally Posted by Skyld

I personally encourage player.clientr.foo.

I do that too. It's good practice that's all.

[fowlplay4]

Originally Posted by scriptless

Why not for client/clientr ?

Because only player objects use client and clientr flags so it seems redundant to me.

[xXziroXx]

Originally Posted by Skyld

I personally encourage player.clientr.foo.

I personally found that more annoying than helpful.

[cbk1994]

Originally Posted by Skyld

I personally encourage player.clientr.foo.

I prefer this as well, for the same reason I use player.setLevel2 or this.func() instead of func().