'No ammo' Problem !

[Trakan]

Okay, hello everyone. I work on a gun script for my server but the problem is with the ammunitions
It say "No ammo" !

PHP Code:

//#CLIENTSIDE
function onPlayerChats() {
if (player.chat = "/ammo"){
  clientr.ammo += 10;
  clientr.capacityammo = 5;
  clientr.maxcapacityammmo = 5;
  setplayerprop #P2,holst_usp45.png;
  replaceani walk,holst_gunwalk;
  replaceani idle,holst_gunidle;
  setplayerprop #c,Ammo added;
}
}
function onWeaponFired() {
  if (clientr.ammo < 0 && clientr.capacityammo != 0) {
  shoot(player.x + vecx(player.dir), player.y + vecy(player.dir), player.z, (playerdir + 1) * pi / 2, NULL, NULL, "holst_bullet", NULL);
  setani("holst_gunfire", NULL);
  clientr.ammo -= 1;
  clientr.capacityammo -= 5;
  freezeplayer(0.75);
} else {
setplayerprop #c,No ammo!;
}
}
function onActionProjectile() {
  player.hearts -= 6;
}
//#CLIENTSIDE
function onKeyPressed( code, key )
{
  if ( key == "e" || key == "E" )
  {
setani("holst_gunreload", NULL);
} 


[Tolnaftate2004]

1. You can't modify clientr variables on the client-side. You can perform tests with client variables, but for security reasons, you will want to use clientr variables, which means you will have to modify them on the server-side. If you don't know what I mean, I'm sure someone will post a link here for you. Otherwise, look into triggeraction, triggerclient, and triggerserver if you're not already familiar.
2. Because clientr.ammo is unchanged, it is 0. Then, when you check if clientr.ammo < 0 (which, I am assuming should in fact be '>'), that test fails.
   
3. You are mixing GS1 and GS2, which is bad form.
   
   To set the player's chat, use player.chat = "foo".
   To set the player's attributes (like #P2), use player.attr[2] = "bar".
   To replace a GANI, use replaceani("baz","qux").
4. Use = as assignment only and use == as comparison only (see the 3rd line in your code). The engine will fix this for you, but it is bad practice.
5. You will only need one //#CLIENTSIDE.

[Gunderak]

Use this serverside to modify a clientr var.

PHP Code:

function onActionServerSide(){
  if(params[0] == "ammo"){
    clientr.whatever = 100;
  }
} 


Then on the clientside to trigger it.

PHP Code:

triggerserver("weapon", this.name, "ammo"); 


Also as I have learnt, style you're code.
Google JavaScript beautifier and run you're code through it.

[Trakan]

Originally Posted by Tolnaftate2004

1. You can't modify clientr variables on the client-side. You can perform tests with client variables, but for security reasons, you will want to use clientr variables, which means you will have to modify them on the server-side. If you don't know what I mean, I'm sure someone will post a link here for you. Otherwise, look into triggeraction, triggerclient, and triggerserver if you're not already familiar.
2. Because clientr.ammo is unchanged, it is 0. Then, when you check if clientr.ammo < 0 (which, I am assuming should in fact be '>'), that test fails.
   
3. You are mixing GS1 and GS2, which is bad form.
   
   To set the player's chat, use player.chat = "foo".
   To set the player's attributes (like #P2), use player.attr[2] = "bar".
   To replace a GANI, use replaceani("baz","qux").
4. Use = as assignment only and use == as comparison only (see the 3rd line in your code). The engine will fix this for you, but it is bad practice.
5. You will only need one //#CLIENTSIDE.

Done, except first step.
Now i have that :

PHP Code:

//#CLIENTSIDE
function onPlayerChats() {
if (player.chat == "/ammo"){
  clientr.ammo += 10;
  clientr.capacityammo = 5;
  clientr.maxcapacityammmo = 5;
  setplayerprop #P2,holst_usp45.png;
  replaceani ("walk","holst_gunwalk");
  replaceani ("idle","holst_gunidle");
  setplayerprop #c,Ammo added;
}
}
function onWeaponFired() {
  if (clientr.ammo > 0 && clientr.capacityammo != 0) {
  shoot(player.x + vecx(player.dir), player.y + vecy(player.dir), player.z, (playerdir + 1) * pi / 2, NULL, NULL, "holst_bullet", NULL);
  setani("holst_gunfire", NULL);
  clientr.ammo -= 1;
  clientr.capacityammo -= 5;
  freezeplayer(0.75);
} else {
player.chat = "No Ammo!";
}
}
if (clientr.ammo == 0) {
player.chat = "No Ammo!";
}
function onActionProjectile() {
  player.hearts -= 6;
}
function onKeyPressed( code, key )
{
  if ( key == "e" || key == "E" )
  {
setani("holst_gunreload", NULL);
}
} 


And Gunderak, where i add this code?

[Gunderak]

I have tried to fix up you're script.
Try this out.

PHP Code:

function onActionServerSide() {
  if (params[0] == "deductammo") {
    clientr.ammo -= 1;
  }
  if (params[0] == "add") {
    clientr.ammo = 10;
    player.attr[15] = "holst_usp45.png";
  }
}

function onActionProjectile() {
  player.hearts -= 6;
}
//#CLIENTSIDE 

function onPlayerChats() {
  if (player.chat == "/ammo") {
    triggerserver("weapon", this.name, "add");
    replaceani("walk", "holst_gunwalk");
    replaceani("idle", "holst_gunidle");
    player.chat == "Ammo Added!";
  }
}

function onWeaponFired() {
  if (clientr.ammo > 0) {
    shoot(player.x + vecx(player.dir), player.y + vecy(player.dir), player.z, (playerdir + 1) * pi / 2, NULL, NULL, "holst_bullet", NULL);
    setani("holst_gunfire", NULL);
    triggerserver("weapon", this.name, "deductammo");
    freezeplayer(0.75);
  } else {
    player.chat = "No Ammo!";
  }
}

function onKeyPressed(code, key) {
  if (key == "e") {
    setani("holst_gunreload", NULL);
    triggerserver("weapon", this.name, "reload");
  }
} 


Also why was there capacityammo, maxcapacityammo and ammo.
You only really need two..
clip and ammo, but for this script you only need ammo.

[callimuc]

Originally Posted by Gunderak

PHP Code:

function onActionProjectile() {
  player.hearts -= 6;
} 


Not sure, but for checking the onActionProjectile() on the serverside, isn´t it onActionProjecttileS() or something like that?

[Trakan]

Originally Posted by Gunderak

I have tried to fix up you're script.
Try this out.

PHP Code:

function onActionServerSide() {
  if (params[0] == "deductammo") {
    clientr.ammo -= 1;
  }
  if (params[0] == "add") {
    clientr.ammo = 10;
    player.attr[15] = "holst_usp45.png";
  }
}

function onActionProjectile() {
  player.hearts -= 6;
}
//#CLIENTSIDE 

function onPlayerChats() {
  if (player.chat == "/ammo") {
    triggerserver("weapon", this.name, "add");
    replaceani("walk", "holst_gunwalk");
    replaceani("idle", "holst_gunidle");
    player.chat == "Ammo Added!";
  }
}

function onWeaponFired() {
  if (clientr.ammo > 0) {
    shoot(player.x + vecx(player.dir), player.y + vecy(player.dir), player.z, (playerdir + 1) * pi / 2, NULL, NULL, "holst_bullet", NULL);
    setani("holst_gunfire", NULL);
    triggerserver("weapon", this.name, "deductammo");
    freezeplayer(0.75);
  } else {
    player.chat = "No Ammo!";
  }
}

function onKeyPressed(code, key) {
  if (key == "e") {
    setani("holst_gunreload", NULL);
    triggerserver("weapon", this.name, "reload");
  }
} 


Also why was there capacityammo, maxcapacityammo and ammo.
You only really need two..
clip and ammo, but for this script you only need ammo.

This work thanks .
I would put a limit-Standing for the charger. When the player shoots 5 balls, it must charge to fulfill its charger.
How can I do it?

[callimuc]

Originally Posted by Trakan

This work thanks .
I would put a limit-Standing for the charger. When the player shoots 5 balls, it must charge to fulfill its charger.
How can I do it?

You can simply add something like (not safe):

PHP Code:

//#CLIENTSIDE
function onWeaponFired() {
  if (clientr.ammo > 0 && this.shootedtimes < 5) {
    shoot(player.x + vecx(player.dir), player.y + vecy(player.dir), player.z, (playerdir + 1) * pi / 2, NULL, NULL, "holst_bullet", NULL);
    setani("holst_gunfire", NULL);
    triggerserver("weapon", this.name, "deductammo");
    this.shootedtimes ++; //increase the times the player fired the weapon
    freezeplayer(0.75);
  }
  else {
    player.chat = "No Ammo!";
    this.shootedtimes = 0; //no ammo or player fired the weapon 5 times? Well than the counter goes back to 0
    setani("reload", NULL);
  }
} 


or safe (just an example)

PHP Code:

function onActionServerSide() {
  if (params[0] == "shootplus") {
    if (clientr.firedtimes < 5) { //just an additional check (needed?)
      clientr.firedtimes ++; //increase the times the player fired the weapon by 1
      clientr.ammo --; //decrease the ammo by 1
    }
  }
  if (params[0] == "shootminus") {
    clientr.firedtimes = 0; //reset the shooting times
  }
}

//#CLIENTSIDE
function onWeaponFired() {
  if (clientr.ammo > 0 && clientr.firedtimes < 5) {
    player.chat = "PENG!";
    triggerserver("weapon", this.name, "shootplus");
    freezeplayer(0.75);
  }
  else {
    player.chat = "No peng :( let´s reload";
    triggerserver("weapon", this.name, "shootminus");
  }
} 


Just something quick bumped

[Tricxta]

Originally Posted by Gunderak

I have tried to fix up you're script....
Also why was there capacityammo, maxcapacityammo and ammo.
You only really need two..
clip and ammo, but for this script you only need ammo.

If you're going to fix his script how's he ever going to learn? If it's browny points you're after you'd do better to explain to him the steps taken to fix the script.

I would recite the give a guy a piece of bread and he'll live a day thing but you already get the point

[Gunderak]

I wasn't after brownie points.
I think the best way to learn is by studying other scripts and trial and error.
That is why I fixed it up a bit.

Also, yes Callimuc I think it's onActionProjectiles(){
I wasnt paying enough attention.