setComments(acc, lines)

cbk1994 · #1 10-17-2009, 09:22 PM

It would be great if a setComments(acc, lines) was added, where lines is an array. This would allow comments to be read and set without giving the NPC-server rw to the accounts folder.

Ideally, there would also be a loadComments(acc), but this can be acheived by giving the NPC-server r to the accounts folder.

fowlplay4 · #2 10-18-2009, 12:43 AM

get and sets for comments would be great.

Rufus · #3 10-18-2009, 01:01 AM

Yeah, it would be cool for things like automatically logging jail history of players.

Matt · #4 10-18-2009, 06:49 AM

Amen to this idea.

TSAdmin · #5 10-18-2009, 09:18 AM

I think this would be a really good idea.

Quote:

Originally Posted by Rufus

Yeah, it would be cool for things like automatically logging jail history of players.

My exact reasoning for thinking it'd be a good idea.

DustyPorViva · #6 10-18-2009, 07:02 PM

Why an array? Just use some sort of parsing format like \b or <br>.

cbk1994 · #7 10-18-2009, 08:04 PM

Quote:

Originally Posted by DustyPorViva

Why an array? Just use some sort of parsing format like \b or <br>.

An array is how it's pulled out of the player file (accounts/whatever) and how it's saved in it, but it really doesn't matter to me.

cbk1994 · #8 11-07-2009, 05:13 AM

bump since Stefan is active on the forums recently

coreys · #9 11-07-2009, 07:52 PM

Quote:

Originally Posted by DustyPorViva

Why an array? Just use some sort of parsing format like \b or <br>.

I think you mean \n

I agree that this would be a very nice feature.

Although I think it would be better to have a more file i/o oriented structure for reading/writing comments. This could also be nice for servers with custom right-click profile systems where staff could read/write comments on the fly without using client rc. :]

Tigairius · #10 11-08-2009, 12:19 AM

Well.. technically this could be scripted in GS2 if the accounts/ folder is enabled on your server since comments are stored in that folder.

cbk1994 · #11 11-08-2009, 02:05 AM

Quote:

Originally Posted by Tigairius

Well.. technically this could be scripted in GS2 if the accounts/ folder is enabled on your server since comments are stored in that folder.

Are you suggesting I give the NPC-server rw access to the accounts folder on Era? lol

fowlplay4 · #12 11-08-2009, 03:04 AM

Quote:

Originally Posted by cbk1994

Are you suggesting I give the NPC-server rw access to the accounts folder on Era? lol

I don't think script even lets you write to it though.

Tigairius · #13 11-08-2009, 05:28 AM

Quote:

Originally Posted by cbk1994

Are you suggesting I give the NPC-server rw access to the accounts folder on Era? lol

Well, basically everything that can be edited with script can be edited in the accounts folder, so it's no different than giving someone NC access or levels rights.

cbk1994 · #14 11-08-2009, 05:38 AM

Quote:

Originally Posted by Tigairius

Well, basically everything that can be edited with script can be edited in the accounts folder, so it's no different than giving someone NC access or levels rights.

Like a staff member's rights or online time?

Tigairius · #15 11-08-2009, 09:26 AM

Quote:

Originally Posted by cbk1994

Like a staff member's rights or online time?

Checkmate.

Anyways, I support this idea.

cbk1994 · #16 04-05-2010, 12:57 PM

Bump. Turns out you can't write to the accounts folder with script anyway (gg jerret).

cbk1994 · #17 06-14-2010, 04:12 PM

Bump.

adam · #18 06-14-2010, 05:50 PM

Clearly this is possible on some level. I've been wanting to understand why the Scripted RC can do things that other scripts cannot? Because clearly there are methods in place to do 'everything' the RC does via script.

cbk1994 · #19 06-14-2010, 06:02 PM

Quote:

Originally Posted by adam

Clearly this is possible on some level. I've been wanting to understand why the Scripted RC can do things that other scripts cannot? Because clearly there are methods in place to do 'everything' the RC does via script.

Nope. The scripted RC uses sendtext. It used to be possible to make your own scripted RC but it was since disabled for non-login scripts.

Cloven · #20 06-14-2010, 06:20 PM

Bump for support. Add the proposed setComments() function please.

adam · #21 06-14-2010, 07:55 PM

Quote:

Originally Posted by cbk1994

Nope. The scripted RC uses sendtext. It used to be possible to make your own scripted RC but it was since disabled for non-login scripts.

Yeah well, I'm still confused about the whole sendtext thing. Clearly the RC type functions only work with the Scripted RC, but it can also be used for other things on other servers, like IRC. So, it seems reasonable to think the comments functions of it could be re-enabled. Unless you can shed some more light on sendtext, and Login scripts for me.

cbk1994 · #22 06-14-2010, 08:23 PM

Quote:

Originally Posted by adam

Yeah well, I'm still confused about the whole sendtext thing. Clearly the RC type functions only work with the Scripted RC, but it can also be used for other things on other servers, like IRC. So, it seems reasonable to think the comments functions of it could be re-enabled. Unless you can shed some more light on sendtext, and Login scripts for me.

Skyld posted the source of the scripted RC at one point. sendText is for communicating with the serverlister (afaik). It's used by all of the login scripts since they don't have a serverside portion (since the server is always changing). The way the scripted RC uses it is definitely not ideal since it requires a staff member to be online. A serverside function is much preferable.

Switch · #23 06-15-2010, 07:13 AM

Quote:

Originally Posted by cbk1994

The way the scripted RC uses it is definitely not ideal since it requires a staff member to be online. A serverside function is much preferable.

Are you sure sendText is disabled, or only on the clientside? I remember Skyld saying it was disabled when I put a sendText serverside and managed to get bans to work.

http://forums.graalonline.com/forums...54&postcount=9

cbk1994 · #24 06-15-2010, 12:14 PM

Quote:

Originally Posted by Switch

Are you sure sendText is disabled, or only on the clientside? I remember Skyld saying it was disabled when I put a sendText serverside and managed to get bans to work.

http://forums.graalonline.com/forums...54&postcount=9

sendText for client-RC commands does not work except from login-priveledged scripts. On serverside I'd doubt it works since there would be no player who is logging into client-RC. Let me know how you did the ban thing, sounds like a big security flaw if it works.

Switch · #25 06-16-2010, 06:26 AM

Quote:

Originally Posted by cbk1994

sendText for client-RC commands does not work except from login-priveledged scripts. On serverside I'd doubt it works since there would be no player who is logging into client-RC. Let me know how you did the ban thing, sounds like a big security flaw if it works.

I'm not sure if it still does work, and I forget exactly what I did but something along the lines of having chat like "/ban Switch 10 test" (/ban account seconds info) sending a trigger to the server and the server doing a sendtext (with "Event Interruption" as the reason).

cbk1994 · #26 06-16-2010, 12:37 PM

Quote:

Originally Posted by Switch

I'm not sure if it still does work, and I forget exactly what I did but something along the lines of having chat like "/ban Switch 10 test" (/ban account seconds info) sending a trigger to the server and the server doing a sendtext (with "Event Interruption" as the reason).

Sounds more like you were using sendToRC? I don't think a sendText would use a "/ban account"... format when you normally pass parameters to it as an array.

Switch · #27 06-16-2010, 06:23 PM

Quote:

Originally Posted by cbk1994

Sounds more like you were using sendToRC? I don't think a sendText would use a "/ban account"... format when you normally pass parameters to it as an array.

What i meant by that was clientside chatting "/ban ..." to send parameters to the server.