Onwater and Keypressed problems

[sssssssssss]

PHP Code:

function onKeyPressed() {
  if (onwater(player.x,player.y)){
    if (keydown(5)) {
      setlevel2("testtourny.nw", 2, 2);
    }
  }
} 


Ok, what am i missing? Pretty sure its a gs2 thing.

[DustyPorViva]

setlevel(2) is serverside.

Also, you may want to detect at player.x+1.5 and playery+2, which is the 'center' of the player.

[Chompy]

I would of done the key check before the water check (:
If this is for an event or something, it would of been easier to alter the player's x/y.

[DustyPorViva]

Originally Posted by Chompy

I would of done the key check before the water check (:

Indeed. No need to check for water if the player isn't even pressing 'S'. Or could even have both in one if statement.

[sssssssssss]

PHP Code:

function onKeyPressed() {
  if (keydown(5)) {
    if (onwater(player.x+1.5,player.y+2)){
      setlevel2("testtourny.nw", 2, 2);
    }
  }
} 


This is the entire script, so it is serverside. Also, didn't change anything to change the order of onwater or keydown. And keydown 5 should be A.

[DustyPorViva]

keypressed/keydown are clientside.

And keydown(5) is 'S' 6 is 'A'.

[sssssssssss]

keydown( key ) the specified key is pressed (0..10: up,left,down,right,S,A,D,M,tab,Q,P)

doesnt work that way anymore?
and forgot about that clientside,

[DustyPorViva]

5 has always been sword and 6 has always been grab If it has ever stated otherwise it was wrong. Easier way to find out what is the right button is to open your control options and the buttons are listed from top to bottom in their numerical order, starting at 0. I actually didn't know about this until someone else posted, but it has come in handy a lot for those keys that I don't use often(like Q/P and such).

[sssssssssss]

PHP Code:

function warpPlayerw(pobj, dest)
  {
  pobj.setlevel2(dest[0], dest[1], dest[2]);
}

//#CLIENTSIDE
function onKeyPressed() {
  if (keydown(6)) {
    if (onwater(player.x+1.5,player.y+2)){
      temp.acct = player.account;
      temp.dest = {testtourny.nw, 2, 2};
      triggeraction(this.x + 0.5, this.y + 0.5, "warpPlayerw", temp.acct, temp.dest);

    }
  }
} 


still getting nothing.

[WhiteDragon]

Originally Posted by sssssssssss

PHP Code:

function warpPlayerw(pobj, dest)
  {
  pobj.setlevel2(dest[0], dest[1], dest[2]);
}

//#CLIENTSIDE
function onKeyPressed() {
  if (keydown(6)) {
    if (onwater(player.x+1.5,player.y+2)){
      temp.acct = player.account;
      temp.dest = {testtourny.nw, 2, 2};
      triggeraction(this.x + 0.5, this.y + 0.5, "warpPlayerw", temp.acct, temp.dest);

    }
  }
} 


still getting nothing.

You sent up the account name, not the player object. Do a findplayer(acct) on the account serverside once you have it.

[LoneAngelIbesu]

This is pretty unrelated, but I have a question about onKeyPressed(). I've seen plenty of people using that action in conjunction with keydown(). Isn't this redundant, since onKeyPressed() has parameters that provide which key is pressed? Why not use a simple check with the parameters, rather than a function?

[WhiteDragon]

Originally Posted by LoneAngelIbesu

This is pretty unrelated, but I have a question about onKeyPressed(). I've seen plenty of people using that action in conjunction with keydown(). Isn't this redundant, since onKeyPressed() has parameters that provide which key is pressed? Why not use a simple check with the parameters, rather than a function?

Yes it is somewhat redundant, but onKeyPressed() gives you the keycode, while keydown() gives you an "action number" which is mapped to a keycode via the settings on the player's client.

It may be possible to access the settings data via. some obscure way, but I'm not sure about that.

[sssssssssss]

PHP Code:

function warpPlayerw(pobj, dest){
  temp.warp = findplayerbycommunityname(pobj);
  warp.setlevel2(dest[0], dest[1], dest[2]);
}

//#CLIENTSIDE
function onKeyPressed() {
  if (keydown(6)) {
    if (onwater(player.x+1.5,player.y+2)){
      temp.acct = player.account;
      temp.dest = {testtourny.nw, 2, 2};
      triggeraction(this.x + 0.5, this.y + 0.5, "warpPlayerw", temp.acct, temp.dest);

    }
  }
} 


still nada. I think I did it right and understood you, if not, please explain in detail. :/

[WhiteDragon]

Originally Posted by sssssssssss

PHP Code:

function warpPlayerw(pobj, dest){
  temp.warp = findplayerbycommunityname(pobj);
  warp.setlevel2(dest[0], dest[1], dest[2]);
}

//#CLIENTSIDE
function onKeyPressed() {
  if (keydown(6)) {
    if (onwater(player.x+1.5,player.y+2)){
      temp.acct = player.account;
      temp.dest = {testtourny.nw, 2, 2};
      triggeraction(this.x + 0.5, this.y + 0.5, "warpPlayerw", temp.acct, temp.dest);

    }
  }
} 


still nada. I think I did it right and understood you, if not, please explain in detail. :/

Yeah, you got that correct.
I just noticed another error was that you didn't put testtourny.nw in quotes, which you need to do for all strings, otherwise it'll try to read it as a variable.

[DustyPorViva]

Originally Posted by LoneAngelIbesu

This is pretty unrelated, but I have a question about onKeyPressed(). I've seen plenty of people using that action in conjunction with keydown(). Isn't this redundant, since onKeyPressed() has parameters that provide which key is pressed? Why not use a simple check with the parameters, rather than a function?

keydown() checks for the player's configuration, while keypressed uses keyboard layout. For example, keydown(5) checks for the player's key configured to 'sword', which may not always be set to 'S'.

[sssssssssss]

Put quotes, still nothing.

[LoneAngelIbesu]

Originally Posted by DustyPorViva

keydown() checks for the player's configuration, while keypressed uses keyboard layout. For example, keydown(5) checks for the player's key configured to 'sword', which may not always be set to 'S'.

Oh, I see. Thanks for the explanation.

[DustyPorViva]

Because triggeractions do not simply call functions, but calls a function specified for triggeractions:
function onactionWhatTriggerWasCalled() {}

would be called with:

triggeractionaction(x,y,"WhatTriggerWasCalled",x,y ,z);

I think.

[sssssssssss]

your right, cant believe i forgot that, its onActionActionHey. now its:

PHP Code:

function onActionWarpPlayerw(pobj, dest){
  temp.warp = findplayerbycommunityname(pobj);
  warp.setlevel2(dest[0], dest[1], dest[2]);
}

//#CLIENTSIDE
function onKeyPressed(6) {
  if (keydown(6)) {
    if (onwater(player.x+1.5,player.y+2)){
      temp.acct = player.account;
      temp.dest = {"testtourny.nw", 2, 2};
      triggeraction(this.x + 0.5, this.y + 0.5, "WarpPlayerw", temp.acct, temp.dest);
    }
  }
} 


but still, not working.

[DustyPorViva]

You also need to setshape(1,32,32) // or whatever the size you want on the serverside(onCreated() is where it should be called) for the server to be able to recognize the NPC.

Ideally, what you can also do is set up a system weapon to have triggers for warping the player, and simply do something like this on the clientside:

triggerServer("gui","-System","WarpPlayer",player.account,dest); // you don't have to use temp.var after you declared the variable a temp.

[sssssssssss]

PHP Code:

function onCreated() {
  this.setshape(1, 32, 32);
}
function onActionWarpPlayerw(pobj, dest){
  temp.warp = findplayerbycommunityname(pobj);
  warp.setlevel2(dest[0], dest[1], dest[2]);
}

//#CLIENTSIDE
function onCreated() {
  this.setshape(1, 32, 32);
}
function onKeyPressed(6) {
  if (keydown(6)) {
    if (onwater(player.x+1.5,player.y+2)){
      temp.acct = player.account;
      temp.dest = {"testtourny.nw", 2, 2};
      triggeraction(this.x + 0.5, this.y + 0.5, "WarpPlayerw", temp.acct, temp.dest);
    }
  }
} 


nada y nada still.

[DustyPorViva]

Debug that motha'!
Start putting player.chat = "test" or something in various places to find out where the script is losing its purpose.

Also, it should just be:

function onKeyPressed() {
if (keydown(6)) {

}
}

Otherwise you're basically defining(or trying to) 6 as a variable for the first parameter of the keypressed function, which may be screwing things up.

Also, temp.warp is not a very descriptive variable name as it's actually referring to a player, so should be something more reflective... at least something like temp.p or such.

[fowlplay4]

On a side note, there's probably a better way to accomplish what you're trying to do, which appears to be some sort of warp the player somewhere if they are in water, the script could easily be replaced by using level warps.

Also your script is incredibly insecure. You don't need to send any extra parameters at all.

PHP Code:

function onActionWarpPlayerw() {
  // Don't really need this array either
  temp.dest = {"testtourny.nw", 2, 2};
  player.setlevel2(dest[0], dest[1], dest[2]);
} 


Then for your triggeraction all you would need is:

triggeraction(this.x + 0.5, this.y + 0.5, "WarpPlayerw", "");

[sssssssssss]

My hero. Thank u everyone. I feel dumb, always forget stupid things like putting a 6 in that function

[Gambet]

I thought I explained triggerAction() to you in multiple posts in the last thread that you asked about it? You should really look back on those posts in the future.

Also, some of you are really bad at helping people with scripting problems, haha. I can't believe it took so long for someone to mention the onActionActionname() bit that he was missing when reading the function called by the triggerAction().

[DustyPorViva]

Originally Posted by Gambet

I thought I explained triggerAction() to you in multiple posts in the last thread that you asked about it? You should really look back on those posts in the future.

Also, some of you are really bad at helping people with scripting problems, haha. I can't believe it took so long for someone to mention the onActionActionname() bit that he was missing when reading the function called by the triggerAction().

I noticed it when he first posted it, lol. I didn't post anything at first though because I wasn't sure of the syntax because it's been so long since I've used triggeraction. I was hoping someone else would notice it :P

[Mark Sir Link]

Originally Posted by fowlplay4

Also your script is incredibly insecure. You don't need to send any extra parameters at all.

since it's being triggered on the clientside, yes. I believe he was still working serverside only when I wrote the function he was trying to use (not in this script I think).

[sssssssssss]

Originally Posted by Gambet

I thought I explained triggerAction() to you in multiple posts in the last thread that you asked about it? You should really look back on those posts in the future.

have been looking back at those posts, lol, trust me. Just went in and looked through again. My problem wasent triggers, that was just a minor accident i did in the code. My problem was working with level triggers and setlevel2. I'm not an advanced scripter, trying to learn as I go. Again thought, thank you now, past, and future to everyone. Would have took me forever to get things like cant use triggerserverside in a level npc.