function onMousedown problem

[PrinceOfKenshin]

Ok so i have two npcs in a level and they both have

PHP Code:

function onMousedown(mode)
{
  if (mode == "double")
{
 triggeraction(0,0,"serverside","System/Main","genderset","male");
}
} 


The only difference between the two is instead of "male" it's "female" in the other npc.

My problem is when i click on the male i get set as the female. And i don't want to have to keep it the way i have it now where you right click for male and left click for female.

[Googi]

Originally Posted by PrinceOfKenshin

My problem is when i click on the male i get set as the female.

Sounds like it could be a problem with the script or part of the script that's being triggered.

[DustyPorViva]

Can't trigger weapons from level NPC's.

[PrinceOfKenshin]

Originally Posted by DustyPorViva

Can't trigger weapons from level NPC's.

Soo i should make a class?

[zokemon]

Originally Posted by DustyPorViva

Can't trigger weapons from level NPC's.

Yes you can.

Originally Posted by PrinceOfKenshin

Soo i should make a class?

CLASSES ARE NOT OBJECTS!

I think your problem is that you don't have any x,y conditions. Maybe you are thinking of onActionMouseDown() or whatever? I only think that works serverside or so though, forgot (haven't been doing level npc scripting much in the past 6 months).

[DustyPorViva]

They can't either, as far as I know.
I honestly have no idea how to tackle this. Maybe some of the more savvy clientside/serverside scripters will have some advice.

EDIT: I've never been able to triggerserver/clientside from an NPC, at least from putnpc's, maybe you can with NPC's in levels. *shrug*

[Inverness]

onActionMouseDown() will work on any level object that has a shape. You'll need setshape on both sides to get it to work clientside and serverside.

Edit: onMouseDown() is detecting of the mouse button is pressed at all, you'll need to check where the mouse actually is yourself. Would probably be better to set a shape and use the action event instead.

Edit2: Btw, I believe its actually onActionLeftMouse() and onActionRightMouse()

PHP Code:

// This is an NPC in a level.
function onCreated() {
  setShape(1, 32, 32);
}
function onActionLeftMouse() {
  echo("You have clicked on the serverside.");
}
//#CLIENTSIDE
function onCreated() {
  setShape(1, 32, 32);
}
function onActionLeftMouse() {
  echo("You have clicked on the clientside.");
} 


Theres also:

PHP Code:

//#CLIENTSIDE
function onMouseDown(mode) {
  if (mousex in |x, x+2| && mousey in |y, y+2|) {
    if (mode == "left") {
      // You left clicked it
    }
    else if (mode == "right") {
      // you right clicked it.
    }
  }
} 


You would also want to check if the GraalControl is the GUI thats focused.

[DustyPorViva]

function onActionleftmouse() {}

[Inverness]

Originally Posted by DustyPorViva

function onActionleftmouse() {}

Indeed, this is basically what Graal is doing automatically for you:

PHP Code:

//#CLIENTSIDE
function onMouseDown(mode) {
  if (mode == "left") {
    triggerAction(mousex, mousey, "LeftMouse", null);
  }
  else if (mode == "right") {
    triggerAction(mousex, mousey, "RightMouse", null); 
  }
} 


[Googi]

Originally Posted by PrinceOfKenshin

Soo i should make a class?

No. First, try disabling or deleting the female-setting NPC to see whether or not the problem is that both are executing. Also, post the code that's being triggered.

[Inverness]

Originally Posted by Googi

No. First, try disabling or deleting the female-setting NPC to see whether or not the problem is that both are executing. Also, post the code that's being triggered.

His problem is that hes executing code when onMouseDown() is triggered without actually checking where the mouse is clicking, so both NPCs run when the mouse is clicked anywhere rather than checking if the mouse clicked on them.

onMouseDown() is called on all objects on the clientside whenever the mouse button is clicked regardless of where.

[Googi]

Originally Posted by Inverness

onMouseDown() is called on all objects on the clientside whenever the mouse button is clicked regardless of where.

I've never seen a script with mousex/mousey conditions following the onMouseDown event, so I assumed this wasn't the case, but indeed it is.

[PrinceOfKenshin]

Hmm i feel a feature request coming.

[Googi]

Originally Posted by PrinceOfKenshin

Hmm i feel a feature request coming.

Huh? Why?

[DustyPorViva]

You can either do what Inverness posted, or simply use the function I posted.

[Inverness]

You should be using onActionLeftMouse() or onActionRightMouse() for level npcs, remember to define the shape.

[Kyranki]

PHP Code:

function GraalControl.onMouseDown(modifier, x, y, clickcount) {
} 


Are the proper number of params.

[zokemon]

Originally Posted by Kyranki

PHP Code:

function GraalControl.onMouseDown(modifier, x, y, clickcount) {
} 


Are the proper number of params.

No, That's for onMouseDown. We are talking about triggering a "click" on a npc here.

[Kyranki]

Originally Posted by zokemon

No, That's for onMouseDown. We are talking about triggering a "click" on a npc here.

Ahhh. Wasn't really paying attention to much here. xD

[PrinceOfKenshin]

Alright thank you my problem is fixed

EDIT: Umm how can i make a bigger range for the person to click?

would i do?

PHP Code:

if (mousex in |x, x+2| && mousey in |y,y+2| && mousex in |,x,x+2| && mousey in |y,y+2|){ 


[Inverness]

|0, 5| would mean 0 or 5 or anything between those.
|x, x+5| would mean anything from the NPC's x coordinate to 5 tiles to the right of the x coordinate.

And like I said before, if you're clicking on NPCs in levels you should use setShape() and onActionLeftMouse()

[PrinceOfKenshin]

Gotcha makes since, yea i changed to onActionDoublemouse()