Guild Script

[Knightmare1]

why wont this script work?

PHP Code:

//#CLIENTSIDE
function onPlayerchats() {
   if (startswith "/guild")
     setcharprop #g, #c;
} 


[oo_jazz_oo]

Well, first off, you cant set a players guild clientside.
Second, I dont like it when people mix gs1 and gs2. -.-
Do something simple like this:

PHP Code:

function onActionGuild(){
player.guild = params[0];
}
//#CLIENTSIDE
function onPlayerChats(){
  if (player.chat.starts("/guild")){
    triggeraction(0,0,"guild",this.name,player.chat.substring(7,-1));
  }
} 


That should do it...

[Kyranki]

PHP Code:

function onActionServerside(acct, gname) {
  temp.pl = findplayer(acct);
  temp.pl.guild = gname;
}
//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat.starts("/guild")) {
    temp.tokens = player.chat.tokenize();
    temp.blah = temp.tokens[0].length() + 1
    triggerserver("weapon", this.name, player.account, player.chat.substring(temp.blah));
  }
} 


Should work.

[zokemon]

Originally Posted by Kyranki

PHP Code:

function onActionServerside(acct, gname) {
  temp.pl = findplayer(acct);
  temp.pl.guild = gname;
}
//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat.starts("/guild")) {
    temp.tokens = player.chat.tokenize();
    temp.blah = temp.tokens[0].length() + 1
    triggerserver("weapon", this.name, player.account, player.chat.substring(temp.blah));
  }
} 


Should work.

Yet horribly insecure!

[oo_jazz_oo]

Originally Posted by zokemon

Yet horribly insecure!

At least he didnt say that about mine. "

[xXziroXx]

Originally Posted by Kyranki

Should work.

Wrong. Missed a semi-colon.

PHP Code:

function onActionServerside(acct, gname) {
  temp.pl = findplayer(acct);
  temp.pl.guild = gname;
}
//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat.starts("/guild")) {
    temp.tokens = player.chat.tokenize();
    temp.blah = temp.tokens[0].length() + 1;
    triggerserver("weapon", this.name, player.account, player.chat.substring(temp.blah));
  }
} 


[DustyPorViva]

Why not just do:
findplayer(acct).guild = gname;

Also, shouldn't you send a parameter such as "changeguild" and check the onactionserverside for it for security measures?

[Kyranki]

Originally Posted by zokemon

Yet horribly insecure!

Come now Zero, he wasn't looking for an extremely complex way of doing several commands. He just wanted a simple way to change the player's guild via chat. o.o

Originally Posted by xXziroXx

Wrong. Missed a semi-colon.

PHP Code:

function onActionServerside(acct, gname) {
  temp.pl = findplayer(acct);
  temp.pl.guild = gname;
}
//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat.starts("/guild")) {
    temp.tokens = player.chat.tokenize();
    temp.blah = temp.tokens[0].length() + 1;
    triggerserver("weapon", this.name, player.account, player.chat.substring(temp.blah));
  }
} 


Trifles.

[Inverness]

PHP Code:

function onActionServerside() {
  if (params[0] == "guildself") {
    player.guild = params[1];
  }
}
//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat.starts("/guild ")) {
    triggerserver("weapon", this.name, "guildself", player.chat.substring(7, -1));
  }
} 


Better.

PHP Code:

//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat.starts("/guild ")) {
    System.serverFunction2(null, "setVar", "player.guild", player.chat.substring(7, -1));
  }
} 


And then my way.

[zokemon]

Originally Posted by Kyranki

Come now Zero, he wasn't looking for an extremely complex way of doing several commands. He just wanted a simple way to change the player's guild via chat. o.o

Oh, I know. I was just making sure he knows that this isn't a script you should really have on a public server since it can easily be abused, hacked, etc.

[Knightmare1]

well, i was thinking of inputing it so only i can use it