Bit of a Problem

[killerogue]

PHP Code:

public function applyStatChange(stat, amt) {
  temp.string = 0;
  tem.plyr = 0;
  
  plyr = findPlayer(this.account);
  
  if (makevar("plyr.clientr.mud." @ stat) == NULL) return;

  if (amt != NULL) {
    if (amt == (abs(amt))) {
      if (stat == "hp" || "mp") {
        if ((makevar("plyr.clientr.mud." @ stat) + amt) <= makevar("plyr.clientr.mud.max" @ stat)) {
          makevar("plyr.clientr.mud." @ stat) += abs(amt);
        }
        else {
          makevar("plyr.clientr.mud." @ stat) = makevar("plyr.clientr.mud.max" @ stat);
        }
      }  
    }
    else {
      if ((makevar("plyr.clientr.mud." @ stat) - amt) > 0) {
        echo("setting a negative");
        makevar("plyr.clientr.mud." @ stat) -= abs(amt);
      }
      else if ((makevar("plyr.clientr.mud." @ stat) - amt) <= 0) { 
        echo("changing to zero");
        makevar("plyr.clientr.mud." @ stat) = 1;
      }
    }
  }
  reflect("player", 3);
  echo(this.mp);
} 


The adding portion of it works perfectly fine, doesn't go over the max amount or anything like that. However as for the subtracting portion, it tends to go over to -599 before it sets it back to 1 the next time I update. What could be the issue?

[Inverness]

PHP Code:

public function applyStatChange(stat, amt) {
  temp.limited = {"hp", "mp"};
  temp.max = 0;
  temp.min = 0;

  if (amt.type() != 0) return; // not a number
  with (findPlayer(this.account)) {
    clientr.mud.(@ stat) += amt;
    if (stat in limited) {
      max = clientr.mud.(@ "max" @ stat);
      min = clientr.mud.(@ "min" @ stat);
      if (clientr.mud.(@ stat) > max)
        amt = max;
      if (clientr.mud.(@ stat) < min)
        amt = min;
    }
  }
} 


[Tolnaftate2004]

Originally Posted by killerogue

PHP Code:

      if (stat == "hp" || "mp") { 


Does not do what you think it does.

Originally Posted by killerogue

PHP Code:

      if ((makevar("plyr.clientr.mud." @ stat) - amt) > 0) { 


If amt is negative.... -amt is positive, so (makevar("plyr.clientr.mud." @ stat) - amt) is adding. So, change the - to + and voila.

[Inverness]

Or just use mine as base.

[Tolnaftate2004]

Originally Posted by Inverness

Or just use mine as base.

It's probably a bad idea to have variables with names min and max.

[Inverness]

Originally Posted by Tolnaftate2004

It's probably a bad idea to have variables with names min and max.

Easy enough to change.

[zokemon]

tem.plry = 0;? :P

[Inverness]

Originally Posted by zokemon

tem.plry = 0;? :P

I noticed that too :P
*coughrookiecough*