Clean Coding - Common Sense

[xXziroXx]

Originally Posted by JkWhoSaysNi

Me either. The spaces inside the ( brackets offend me too

Heres how I do it:

PHP Code:

if (var) {
       ...
} 


i guess if (var) has more meaning if you name your boolean variables as verbs as I tend to do e.g. if (finished)

Same as me then, although I would do:

PHP Code:

if (var == true) {
       ...
} 


[Skyld]

PHP Code:

if (var)
{
  // ...
} 


I don't see the point in putting var == true when that's already implied, and I prefer brackets on their own line. It improves spacing and clarity.

[Crow]

Originally Posted by Skyld

PHP Code:

if (var)
{
  // ...
} 


I don't see the point in putting var == true when that's already implied, and I prefer brackets on their own line. It improves spacing and clarity.

Lines++ ;/

[Skyld]

Originally Posted by Crow

Lines++ ;/

Doesn't really matter. The script will be folded into the same amount of bytecodes with new lines as it is with brackets on the same lines.

The fact is that it's clearer when I'm editing the script.

[JkWhoSaysNi]

That's not a fact it's entirely subjective :P

I think less lines is clearer. I think it's easier to see which statement a block belongs to when the opening bracket is on the same line.

[xXziroXx]

Originally Posted by JkWhoSaysNi

That's not a fact it's entirely subjective :P

I think less lines is clearer. I think it's easier to see which statement a block belongs to when the opening bracket is on the same line.

Agreed.

[Novo]

PHP Code:

function onKilled()
  {
  var;
  } 


I r bestest in Teh World!

[Skyld]

Originally Posted by JkWhoSaysNi

That's not a fact it's entirely subjective :P

Originally Posted by Skyld

The fact is that it's clearer when I'm editing the script.

I.

[Novo]

Originally Posted by Skyld

I.

I.

[cbk1994]

Originally Posted by Novo

I.

I.
--
Less lines? Really.

PHP Code:

//#CLIENTSIDE
function onCreated() { dothis(); thendothis(); thenletthis = "foo"; thendosomethingelse(); timetomilkthecow();doOTHERSTUFF()} function doOTHERSTUFF() { noWAI(); } function noWAI() { player.chat = "MUAHAHAHAHAHAHAH!"; } 


Whoah you're right, that's really neat and clean!

[Kristi]

Originally Posted by Twinny

I. (Question how long this thread will survive )

I (decided it will go on no longer)

[Sam]

Next time I see people power spamming a serious thread like this, I will spread also power infraction points for each spam post.

3) SPAM

a) Posting of spam is not allowed. Spam is defined as any irrelevant or inappropriate message. Due to the nature of the forums, what is considered spam varies between threads. In other words: in some threads, small posts such as "..." are perfectly valid responses, whereas in other threads it is inappropriate. The context of the message is very important in this regard. It is the right and responsibility of the administrators or moderators to determine whether or not a message is spam and to take appropriate action if it is.

[Kristi]

I am reopening this for the sake of clean coding discussion. No spam tolerence here!

[cbk1994]

Originally Posted by Novo

PHP Code:

function onKilled()
  {
  var;
  } 


I r bestest in Teh World!

The brackets really need to be on their own line ...

What do you people mean you only give brackets a new line for functions? How are functions any different in that structure than an if () or while (), or w/e?

[xXziroXx]

Originally Posted by cbkbud

The brackets really need to be on their own line ...

What do you people mean you only give brackets a new line for functions? How are functions any different in that structure than an if () or while (), or w/e?

Example:

PHP Code:

function BLAH()
{  // See? NEW LINE!
  if (lawl == "xXx") {  // See? NO NEW LINE!
  }
} 


[Twinny]

PHP Code:

function blah()
{
  if (this.condition)
  {
    if (this.completelydifferentcondition)
      blah2();
    else
      blah3();
  }  
} 


My general stylings. I normally have brackets around all conditions and events but when i'm finished and there is only one statement, I generally remove them.

Like

PHP Code:

function Dosomething()
  return this.something.index();

public function yay()
  return localfunction(); 


[Skyld]

Originally Posted by xXziroXx

Example:

PHP Code:

function BLAH()
{  // See? NEW LINE!
  if (lawl == "xXx") {  // See? NO NEW LINE!
  }
} 


Eh. That sorta screams 'inconsistency'.

[cbk1994]

Originally Posted by xXziroXx

Example:

PHP Code:

function BLAH()
{  // See? NEW LINE!
  if (lawl == "xXx") {  // See? NO NEW LINE!
  }
} 


Any logic behind that? Seems a little hard to follow.

Twinny -- why don't you use brackets for one statement? They make it a lot cleaner, and neater, and if you need to adjust something it looks better.

PHP Code:

if ( foo )
{
  doSomething();
} 


[xXziroXx]

Originally Posted by Skyld

Eh. That sorta screams 'inconsistency'.

It can scream whatever it wants, aslong as I like to script like that.

[cbk1994]

Originally Posted by xXziroXx

It can scream whatever it wants, aslong as I like to script like that.

That's one way to think about it.