Clean Coding - Common Sense

[Gambet]

Yeah, your old method of not styling at all and scripting like this:

PHP Code:

function onCreated(){
player.chat="Rapid's styling sucks major wang";
setTimer(1);
}

function onTimeOut(){
this.yourstylingoldstylingsucks;;
chat="You grouped everything together without any spacing";
echo("And it was very annoying to read");
setTimer(1);
} 


Or something like that....



It was very annoying and barely legible.

[Bl0nkt]

Originally Posted by Gambet

Yeah, your old method of not styling at all and scripting like this:

PHP Code:

function onCreated(){
player.chat="Rapid's styling sucks major wang";
setTimer(1);
}

function onTimeOut(){
this.yourstylingoldstylingsucks;;
chat="You grouped everything together without any spacing";
echo("And it was very annoying to read");
setTimer(1);
} 


Or something like that....



It was very annoying and barely legible.

Looks fine to me

[killerogue]

Originally Posted by Bl0nkt

Looks fine to me

You wonder why scripters hate looking at your scripts Hachi?

[Chandler]

I'd do this:

PHP Code:

public function Hurt(hurtDamage, attackersAccount, hurtGani)
  if (this.clientr.hp > 0 && !this.clientr.dead && !level.nopk && !this.client.nopk)
  {
  this.clientr.hp -= abs(temp.hurtDamage);  
  if (temp.hurtGani) 
    this.setAni("hurt", "");
  clientr.lastattacker = temp.attackersAccount;
  if (this.clientr.hp <= 0) 
    this.doDeath(temp.attackersAccount);
  this.showHp(7);
  }
public function doDeath(attackersAccount)
  {
  this.clientr.dead = true;
  this.clientr.hp = 0;
  this.Kill(temp.attackersAccount); 
  } 


[Angel_Light]

Yes this has happened to me too *sneeze*TheFox*sneezes* I just used the Servers style command

/style Type Name

Like when Fox made a weapon I couldnt read I did

/Style weapon -FoxTest

it's not "my" style but it organizes the code.

[godofwarares]

Originally Posted by Angel_Light

Yes this has happened to me too *sneeze*TheFox*sneezes* I just used the Servers style command

/style Type Name

Like when Fox made a weapon I couldnt read I did

/Style weapon -FoxTest

it's not "my" style but it organizes the code.

Simple yet effective

[Skyld]

Originally Posted by Chandler

I'd do this:

PHP Code:

public function Hurt(hurtDamage, attackersAccount, hurtGani)
  if (this.clientr.hp > 0 && !this.clientr.dead && !level.nopk && !this.client.nopk)
  {
  this.clientr.hp -= abs(temp.hurtDamage);  
  if (temp.hurtGani) 
    this.setAni("hurt", "");
  clientr.lastattacker = temp.attackersAccount;
  if (this.clientr.hp <= 0) 
    this.doDeath(temp.attackersAccount);
  this.showHp(7);
  }
public function doDeath(attackersAccount)
  {
  this.clientr.dead = true;
  this.clientr.hp = 0;
  this.Kill(temp.attackersAccount); 
  } 


Ugh, that makes my eyes bleed. Your brackets should be inline with the block, not with the contents. You've missed out a load of brackets anyway, and you've mixed all sorts of conditional checks which are totally unrelated to each other in one line. :/ Bleugh.

[xXziroXx]

Originally Posted by Skyld

Ugh, that makes my eyes bleed. Your brackets should be inline with the block, not with the contents. You've missed out a load of brackets anyway, and you've mixed all sorts of conditional checks which are totally unrelated to each other in one line. :/ Bleugh.

I second that..

[cbk1994]

Originally Posted by Rapidwolve

I recently have been practicing better organization and clean coding in my scripts, heres a snippet.

PHP Code:

public function Hurt(damage, attacker, hurtani){
  temp.conditionsok = ((this.clientr.hp > 0 && this.clientr.dead == false && level.nopk == false && this.client.nopk == false) ? true : false);
   if (temp.conditionsok){
       if (temp.damage => this.clientr.hp) {
        this.clientr.hp = 0;
        this.Kill(temp.attacker); 
        this.showHp(7);
        return;
       }
       if (temp.hurtani) this.setani("hurt", null);
          clientr.lastattacker = temp.attacker;
          this.clientr.hp -= abs(temp.damage);
          this.showHp(7);
    }
    return;
} 


Looks nice, but personally I prefer

PHP Code:

if (temp.hurtani == true) 


instead of

PHP Code:

if (temp.hurtani) 


and I'd recommend braces for everything anyway.

Hachi ... I'd be scared to see your scripting.

[Rapidwolve]

Originally Posted by Gambet

Yeah, your old method of not styling at all and scripting like this:

PHP Code:

function onCreated(){
player.chat="Rapid's styling sucks major wang";
setTimer(1);
}

function onTimeOut(){
this.yourstylingoldstylingsucks;;
chat="You grouped everything together without any spacing";
echo("And it was very annoying to read");
setTimer(1);
} 


Or something like that....



It was very annoying and barely legible.

I never styled like that x.x

[Chandler]

Originally Posted by Skyld

Ugh, that makes my eyes bleed. Your brackets should be inline with the block, not with the contents. You've missed out a load of brackets anyway, and you've mixed all sorts of conditional checks which are totally unrelated to each other in one line. :/ Bleugh.

*****.

[Chompy]

Someone (Well, a couple) told me to change my styling so...

PHP Code:

public function Hurt(damage, attacker, hurtani) {
  temp.conditionsok = ((this.clientr.hp > 0 && this.clientr.dead == false && level.nopk == false && this.client.nopk == false) ? true : false);
  if (temp.conditionsok) {

    if (temp.damage => this.clientr.hp) {
      this.clientr.hp = 0;
      this.Kill(temp.attacker); 
      this.showHp(7);
      return NULL;
    }
    if (temp.hurtani)
      this.setani("hurt", NULL);

    this.clientr.lastattacker = temp.attacker;
    this.clientr.hp -= abs(temp.damage);
    this.showHp(7);
    return NULL;
  }
} 


(Based of RW's script)

[Angel_Light]

I don't care what people think of my styling it's makes scripting easier for me and allows ME to read it better/quicker. But when ever I do post a snippet I usually do use the /style.

[cbk1994]

Originally Posted by Chompy

Someone (Well, a couple) told me to change my styling so...

PHP Code:

public function Hurt(damage, attacker, hurtani) {
  temp.conditionsok = ((this.clientr.hp > 0 && this.clientr.dead == false && level.nopk == false && this.client.nopk == false) ? true : false);
  if (temp.conditionsok) {

    if (temp.damage => this.clientr.hp) {
      this.clientr.hp = 0;
      this.Kill(temp.attacker); 
      this.showHp(7);
      return NULL;
    }
    if (temp.hurtani)
      this.setani("hurt", NULL);

    this.clientr.lastattacker = temp.attacker;
    this.clientr.hp -= abs(temp.damage);
    this.showHp(7);
    return NULL;
  }
} 


(Based of RW's script)

I've never seen of return NULL. Any different from return false;?

--

There's more to scripting than you reading it. It needs to be legible for others too.

[Chompy]

Originally Posted by cbkbud

I've never seen of return NULL. Any different from return false;?

return NULL; is just to clear out that it is not returning to a function nor returning a value.

[Kristi]

Originally Posted by cbkbud

Looks nice, but personally I prefer

PHP Code:

if (temp.hurtani == true) 


instead of

PHP Code:

if (temp.hurtani) 


and I'd recommend braces for everything anyway.

Hachi ... I'd be scared to see your scripting.

What? if(something == true)? ::hits::

[JkWhoSaysNi]

checking "if (var == true)" is redundant unless you're not sure on the type of the variable.

[cbk1994]

Originally Posted by JkWhoSaysNi

checking "if (var == true)" is redundant unless you're not sure on the type of the variable.

Works fine ... to me it seems simpler.

if ( var == 1 )

better?

[JkWhoSaysNi]

if (var) is simpler and more efficient.

when you do if (var == true) the interpreter is basically doing 2 checks.

[cbk1994]

I see. I'll try to get used to that, though I suppose it doesn't matter that much now that I see it

[Rapidwolve]

Originally Posted by Skyld

Ugh, that makes my eyes bleed. Your brackets should be inline with the block, not with the contents. You've missed out a load of brackets anyway, and you've mixed all sorts of conditional checks which are totally unrelated to each other in one line. :/ Bleugh.

I thought that was directed to me x.x

[Chompy]

Originally Posted by Rapidwolve

I thought that was directed to me x.x

Thread revival xD

[Inverness]

Originally Posted by Chompy

return NULL; is just to clear out that it is not returning to a function nor returning a value.

Null IS a value, zero actually. You could just do return; anyways.

And I think Stefan should make the compiler optimize if (var == true) since that looks nicer than if (var) which makes me think of the horrors of GS1.

[JkWhoSaysNi]

Except Gscipt isn't compiled it's interpreted. If it were compiled then the compiler could optimise the statement (by turning it into if (var) ) but since it's interpreted I don't think theres any way to do it.

Anyway, the difference in speed is negligible. Just use if (var == true) if it makes it easier to read.

[godofwarares]

Everyone has their own style of coding, and they can read it. It doesn't matter if other people can't. I style similar to Skyld's styling, mainly because I find his scripts readable and he kinda pushed me to it :P

[Inverness]

GScript is not interpreted, its Compiled when you save the script. Thats how scripts are sent to the client Pre-Compiled like Stefan said. Unless Stefan has a different definition of Compiled.

[Twinny]

I think they are optimised a bit and compiled into byte code.

[godofwarares]

Its compiled into byte code, because they're all stored on your computer if you look closely enough.

Every time you add yourself a weapon, that compiled code goes directly into your computer, probably to lessen the load on the server.

[cbk1994]

if (var) always reminded me of GS1 ... I still have nightmares about that.

[Inverness]

PHP Code:

if (playerchats) {
  tokenize #c;
  if (strequals(#t(0),kill:)) {
    with (getplayer(#t(1))) {
      playerhearts = 0;
    }
  }
} 


[JkWhoSaysNi]

Originally Posted by Inverness

GScript is not interpreted, its Compiled when you save the script. Thats how scripts are sent to the client Pre-Compiled like Stefan said. Unless Stefan has a different definition of Compiled.

I stand corrected. I always thought it was just interpreted.

The compiler could potentially optimise the code then.

[Skyld]

Originally Posted by JkWhoSaysNi

I stand corrected. I always thought it was just interpreted.

The compiler could potentially optimise the code then.

Scripts are folded when they are compiled so that they are more efficient.

[cbk1994]

I would find it annoying if I wrote

PHP Code:

if ( var == 1 ) 


and it changed it to

PHP Code:

if ( var == true ) 


[zokemon]

Usually the ammount of styling and the importance of a scripter's styling to himself usually reflects his skill with Graal coding.

Pretty hard to do complex scripts if you have horrible spacing

[Inverness]

Originally Posted by zokemon

Usually the ammount of styling and the importance of a scripter's styling to himself usually reflects his skill with Graal coding.

Pretty hard to do complex scripts if you have horrible spacing

Irrelevant if your typing speed is excellent.

[xXziroXx]

I, too, think that example A looks better then example B.

A: if (var == true) { .... }
B: if (var) { .... }

[Rapidwolve]

Originally Posted by xXziroXx

I, too, think that example A looks better then example B.

A: if (var == true) { .... }
B: if (var) { .... }

Thats how I had it on my script first, I forgot why I changed it

[cbk1994]

Originally Posted by xXziroXx

I, too, think that example A looks better then example B.

A: if (var == true) { .... }
B: if (var) { .... }

C:

PHP Code:

if ( var == true )
{
    ...
} 


C seems better than both

[xXziroXx]

Originally Posted by cbkbud

C:

PHP Code:

if ( var == true )
{
    ...
} 


C seems better than both

No way! I only make new lines for brackets on functions. And I just dont like that way of spacing

[JkWhoSaysNi]

Me either. The spaces inside the ( brackets offend me too

Heres how I do it:

PHP Code:

if (var) {
       ...
} 


i guess if (var) has more meaning if you name your boolean variables as verbs as I tend to do e.g. if (finished)