Graal Forums  

Go Back   Graal Forums > Graal V6 forums > Your opinion
FAQ Members List Calendar Search Today's Posts Mark Forums Read

Closed Thread
 
Thread Tools Search this Thread Rate Thread Display Modes
  #91  
Old 05-28-2008, 02:34 PM
Chompy Chompy is offline
¯\(º_o)/¯
Chompy's Avatar
Join Date: Sep 2006
Location: Norway
Posts: 2,815
Chompy is just really niceChompy is just really niceChompy is just really nice
Send a message via MSN to Chompy
Quote:
Originally Posted by Robin View Post
player.account > player.communityname
  • new player attribute player.communityname which displays the name the player is using for the forums etc.
    • by default players have now an account name which is basicly just a number (Graal12345) and can later register a communityname which is then used for the fourms, wiki etc.
    • on the playerlist and PMs it will display the community name instead of the account name, scripts are supposed to do the same

1. I haven't done much testing but I'm assuming it's safe to just use community name where you would previously just use account.

2. Unless of course, those with old account names but never had any access to the forum and thus have never registered a community name, makes the community name return null?

If the same goes with new accounts who have not yet registered a community name (which of course does suck) but a simple fix would be to fall back to the account name or even the nickname of the player to assertain identity.

However, nicknames are not as secure as the previous two options.

I'll do some testing later today and post my findings in the scripting forum if you like Crow?
1. You can't use findplayer() on communitynames..
2. Old accounts before the comunitynames will get their community name set to their account so account == communityname in their case
__________________
  #92  
Old 05-28-2008, 02:56 PM
Crow Crow is offline
ǝɔɐɹq ʎןɹnɔ
Crow's Avatar
Join Date: Dec 2006
Location: Germany
Posts: 5,153
Crow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond repute
Thanks for the offer Robin, but I have done enough and I might also say too much testing on this already. It just sucks. Think about commands like /itemtrade on Era. It's asking for the account to trade to (or did so in the past). Nobody wants to use Graalxxxxxx accounts for that, but if people don't have a community name I also have to code something that allows people to put both account and community name. That's just ****in complicated.
__________________
  #93  
Old 05-28-2008, 03:17 PM
Robin Robin is offline
The secret of NIMH
Robin's Avatar
Join Date: Apr 2005
Location: Wales, UK
Posts: 515
Robin will become famous soon enough
Send a message via AIM to Robin Send a message via Skype™ to Robin
Quote:
Originally Posted by Chompy View Post
1. You can't use findplayer() on communitynames..
2. Old accounts before the comunitynames will get their community name set to their account so account == communityname in their case
1. findplayerbycommunityname(str) returns object
2. What about new accounts?
__________________

  #94  
Old 05-28-2008, 03:32 PM
blazeingonix blazeingonix is offline
† Ðяΰм & βâsş †
blazeingonix's Avatar
Join Date: Apr 2007
Location: PlayBoy Mansion
Posts: 537
blazeingonix is an unknown quantity at this point
Send a message via MSN to blazeingonix
Lot of accounts with Graal1349595 , Graa19394 and i can't remember who they're this suck .
__________________
  #95  
Old 05-28-2008, 03:53 PM
Chompy Chompy is offline
¯\(º_o)/¯
Chompy's Avatar
Join Date: Sep 2006
Location: Norway
Posts: 2,815
Chompy is just really niceChompy is just really niceChompy is just really nice
Send a message via MSN to Chompy
Quote:
Originally Posted by Crow View Post
Thanks for the offer Robin, but I have done enough and I might also say too much testing on this already. It just sucks. Think about commands like /itemtrade on Era. It's asking for the account to trade to (or did so in the past). Nobody wants to use Graalxxxxxx accounts for that, but if people don't have a community name I also have to code something that allows people to put both account and community name. That's just ****in complicated.
I always use something like this or something :o
Graal Script Code:
  a pl.communityname;
  if (
== 0pl.account;
  else if (
== "guest"pl.account
so..

Graal Script Code:
function checkPlayer(plyr) {
  
temp.findplayer(plyr);
  if (
== 0findplayerbycommunityname(plyr);
  if (
== 0) return 0;
  return 
1;

something like that would do it, but I haven't tested it though..

Quote:
Originally Posted by Robin View Post
1. findplayerbycommunityname(str) returns object
2. What about new accounts?
1. You stated that we could just use communityname where we used accounts, not true as I stated that you can't use findplayer() and that has been used since gs2 came out. findplayerbycommunityname() was added some weeks after the communitynames came out because of complaints in the scripting forum..

2. New accounts can choose their own communityname once logged on graalonline.com and then by editing their profile from there if I recall.

I would like findplayer() to work with both findplayerbycommunityname() is too long.. and I don't like to make something like

Graal Script Code:
public function findcommunityplayer(a) {
  return 
findplayerbycommunityname(a);

or something like that..
__________________
  #96  
Old 05-28-2008, 04:21 PM
Robin Robin is offline
The secret of NIMH
Robin's Avatar
Join Date: Apr 2005
Location: Wales, UK
Posts: 515
Robin will become famous soon enough
Send a message via AIM to Robin Send a message via Skype™ to Robin
Quote:
Originally Posted by Chompy View Post
Graal Script Code:
function checkPlayer(plyr) {
  
temp.findplayer(plyr);
  if (
== 0findplayerbycommunityname(plyr);
  if (
== 0) return 0;
  return 
1;

Jesus chompy what are you doing to me man, you scared the crap out of me.

Before you edited your post I had this in the quick reply box:

Graal Script Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  if (
temp.== 0) {
    
temp.findplayer(pl);
    if (
temp.== 0) {
      return 
0;
    } else {
      return 
temp.p;
    }
  } else {
    return 
temp.p;
  }

[EDIT]
Actually that can probably be optimised:

Graal Script Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  return 
== findplayer(pl) : p;

[/EDIT]
__________________

  #97  
Old 05-28-2008, 04:30 PM
Chompy Chompy is offline
¯\(º_o)/¯
Chompy's Avatar
Join Date: Sep 2006
Location: Norway
Posts: 2,815
Chompy is just really niceChompy is just really niceChompy is just really nice
Send a message via MSN to Chompy
Quote:
Originally Posted by Robin View Post
Jesus chompy what are you doing to me man, you scared the crap out of me.

Before you edited your post I had this in the quick reply box:

Graal Script Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  if (
temp.== 0) {
    
temp.findplayer(pl);
    if (
temp.== 0) {
      return 
0;
    } else {
      return 
temp.p;
    }
  } else {
    return 
temp.p;
  }

[EDIT]
Actually that can probably be optimised:

Graal Script Code:
function _getPlayer(pl) {
  
temp.findplayerbycommunityname(pl);
  return 
== findplayer(pl) : p;

[/EDIT]
hehe


and, about your edit, that's not optimised though, as it does the same amount of checks .. linecount however is smaller
__________________
  #98  
Old 05-28-2008, 05:00 PM
Robin Robin is offline
The secret of NIMH
Robin's Avatar
Join Date: Apr 2005
Location: Wales, UK
Posts: 515
Robin will become famous soon enough
Send a message via AIM to Robin Send a message via Skype™ to Robin
two is the smallest amount of checks but if you notice it only does one if statement instead of two, hence optimised (although not by much)
__________________

  #99  
Old 05-28-2008, 05:16 PM
Crow Crow is offline
ǝɔɐɹq ʎןɹnɔ
Crow's Avatar
Join Date: Dec 2006
Location: Germany
Posts: 5,153
Crow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond repute
Quote:
Originally Posted by Robin View Post
two is the smallest amount of checks but if you notice it only does one if statement instead of two, hence optimised (although not by much)
Still needs Chompsters "guest" check included, thats really important. Chompy, yes, I'm using something similar. Still annoying me thinks.
__________________
  #100  
Old 05-28-2008, 05:17 PM
Chompy Chompy is offline
¯\(º_o)/¯
Chompy's Avatar
Join Date: Sep 2006
Location: Norway
Posts: 2,815
Chompy is just really niceChompy is just really niceChompy is just really nice
Send a message via MSN to Chompy
Quote:
Originally Posted by Robin View Post
two is the smallest amount of checks but if you notice it only does one if statement instead of two, hence optimised (although not by much)
There's an 'else' in there though

return p == 0 ? findplayer(pl) : p
if (p == 0) return findplayer(pl) else return p;
__________________
  #101  
Old 05-28-2008, 06:16 PM
Frankie Frankie is offline
xChugxLifex
Frankie's Avatar
Join Date: Feb 2008
Location: New York
Posts: 1,610
Frankie is a jewel in the roughFrankie is a jewel in the rough
Send a message via AIM to Frankie Send a message via MSN to Frankie
I honestly don't see what potential Stefan/Unix saw in this dumb account system.
__________________
*Sum41Freeeeek
*Frankie
  #102  
Old 05-28-2008, 06:40 PM
Crow Crow is offline
ǝɔɐɹq ʎןɹnɔ
Crow's Avatar
Join Date: Dec 2006
Location: Germany
Posts: 5,153
Crow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond repute
Quote:
Originally Posted by Chompy View Post
There's an 'else' in there though

return p == 0 ? findplayer(pl) : p
if (p == 0) return findplayer(pl) else return p;
Those two lines equal.


Quote:
Originally Posted by Frankie View Post
I honestly don't see what potential Stefan/Unix saw in this dumb account system.
Original idea was that trials can't take "good" account names anymore but still keep what they have done while playing without a community name.
__________________
  #103  
Old 05-28-2008, 06:57 PM
Robin Robin is offline
The secret of NIMH
Robin's Avatar
Join Date: Apr 2005
Location: Wales, UK
Posts: 515
Robin will become famous soon enough
Send a message via AIM to Robin Send a message via Skype™ to Robin
Note the nested if in the if statement in my other post. I saved amount of if statements x 2.

ANYWAY, Back to topic, Why don't they remove trials completely, you have a guest account, and then when you sign up properly you can sign up a proper account name?

The graal14289452359234534258234905839024589239045 crap is really awful.
__________________

  #104  
Old 05-28-2008, 07:25 PM
Crow Crow is offline
ǝɔɐɹq ʎןɹnɔ
Crow's Avatar
Join Date: Dec 2006
Location: Germany
Posts: 5,153
Crow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond reputeCrow has a reputation beyond repute
Quote:
Originally Posted by Robin View Post
Note the nested if in the if statement in my other post. I saved amount of if statements x 2.

ANYWAY, Back to topic, Why don't they remove trials completely, you have a guest account, and then when you sign up properly you can sign up a proper account name?

The graal14289452359234534258234905839024589239045 crap is really awful.
Eh, trials are removed, when I said trial I meant guests. Actually, yea, doing that wouldn't be a problem at all. I mean, people could register custom account names for years. Why not now? This was never a problem, your account is not your nickname or something.
__________________
  #105  
Old 05-28-2008, 11:31 PM
Elizabeth Elizabeth is offline
a/s/l
Elizabeth's Avatar
Join Date: Jul 2006
Location: Canada
Posts: 5,018
Elizabeth has much to be proud ofElizabeth has much to be proud ofElizabeth has much to be proud ofElizabeth has much to be proud ofElizabeth has much to be proud ofElizabeth has much to be proud of
Send a message via AIM to Elizabeth
Quote:
Originally Posted by kia345 View Post
That has to be the stupidest update yet. Good job
agreed
__________________
<3
Closed Thread

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes Rate This Thread
Rate This Thread:

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 07:58 PM.


Powered by vBulletin® Version 3.8.3
Copyright ©2000 - 2019, Jelsoft Enterprises Ltd.
Copyright (C) 1998-2008 Linux cyberjoueurs All Rights Reserved.