players in room

[bashjgovers]

hey i wanna make a event house where the people dont need ET to play events. I wanna make the doors will open automatic when there are enough players in the room. Can anyone help me with this?

[Neoreno]

Use a for loop and the playercount variable.

[Snakeandy7]

Wasnt there a command like
if (playerscount == 2){..}
Bla, But i'd listen to kiirar, the loop is the best direction to go

[Knuckles]

Originally posted by Snakeandy7
Wasnt there a command like
if (playerscount == 2){..}
Bla, But i'd listen to kiirar, the loop is the best direction to go

...That's close to what Kirrar's saying.

Use a for loop and the playercount variable.

And you mean a timeout loop?

[Neoreno]

No. I mean a for loop.


Edit: I re-read what they wanted, a timeout loop would be more useful in this case.

[marcoR]

ok... i'm no scripting genius, heck, i can barelly make a door

but wouldn't it look like this?

NPC Code:

---

timeout=0.5;



if (timeout && playercount>5){

  do something;

  timeout=0.5;

}

---

but I don't know, i've never used player count, and heck, i suck at scripting..

[protagonist]

Originally posted by marcoR
ok... i'm no scripting genius, heck, i can barelly make a door

but wouldn't it look like this?

NPC Code:

---

timeout=0.5;



if (timeout && playercount>5){

  do something;

  timeout=0.5;

}

---

but I don't know, i've never used player count, and heck, i suck at scripting..

Don't declare flags/variables etc. outside of code blocks. In addition, do not have an event check and a conditional check in the same if (statement). I suggest defining timeout in playerenters.

[Neoreno]

Well. The timeout is too infrequent. A timeout of 0.05 would do.
The variable is playerscount I believe. Not to mention it doesn't conform to KSI-GS standards.

[Tseng]

Originally posted by protagonist


In addition, do not have an event check and a conditional check in the same if (statement).

The logic behind this is...?

[marcoR]

not the standards!? NO!!! *cuts hand off* it was an example, sheesh, and what's wrong with doing that? (give me a good reason and i'll never do it again)

[edit]
sorry about the timeout I always do that.. I don't even know why, I meant 0.05 tho.
[/edit]

[protagonist]

Originally posted by Tseng


The logic behind this is...?

It is neater. Read KSI-GS standards thread.

[marcoR]

meh, I guess I'll fall to the wrain of kai...

so would it be like this?

NPC Code:

---

timeout=0.05;



if (timeout){

  if(playerscount>5){

     do something, please!;

   }

  timeout=0.05;

}

---

atleast that's how I understood it...

[protagonist]

Originally posted by marcoR
meh, I guess I'll fall to the wrain of kai...

so would it be like this?

NPC Code:

---

timeout=0.05;



if (timeout){

  if(playerscount>5){

     do something, please!;

   }

  timeout=0.05;

}

---

atleast that's how I understood it...

You should still need to define timeout in a code block.

[marcoR]

than like this!?

NPC Code:

---

if (created){

  timeout=0.05;

}



if (timeout){

  if(playerscount>5){

     do something, please!;

   }

  timeout=0.05;

}

---

!?

[osrs]

Originally posted by marcoR
than like this!?

NPC Code:

---

if (created){

  timeout=0.05;

}



if (timeout){

  if(playerscount>5){

     do something, please!;

   }

  timeout=0.05;

}

---

!?

Yes.

[Snakeandy7]

Lol, finally he got it, still chance for you zero.
Anywho you could of done
if (playerenters || timeout){
}
lol, Anywho

[marcoR]

I knew how to make it work, I just didn't know how to do it propperly.

[Snakeandy7]

Originally posted by marcoR
I knew how to make it work, I just didn't know how to do it propperly.

You got there in the end

[Riot-Starter]

Just a side note:
playerscount includes NPCs when used clientside.

[Python523]

Originally posted by Riot-Starter
Just a side note:
playerscount includes NPCs when used clientside.

only showcharacter ones I believe, unless that was changed

[Riot-Starter]

Originally posted by Python523


only showcharacter ones I believe, unless that was changed

I think it is only showcharacters, I just remember problems with gralats causing spar room doors to stay closed.
Although there is an easy fix to determine whether it’s an NPC or player.

[Tseng]

Originally posted by protagonist



It is neater. Read KSI-GS standards thread.

Neater? Subjective. I find it neater to have a balance of lines and lengths. You find it neater to have one check per line. When they are related (as they are in this case), I find it unnecessary to split it up. Perhaps I should paste the first line of the first if check in the hpfunctions subroutine on graal2001, and ask if those shouldn't be split up.

One line of two related checks (an event and a condition) and splitting them up one to each line is the same code - so you can't really argue efficiency or optimization, but only a stylistic choice.

(Additionally, the standards thread does not mention putting an event and a condition on separate lines.

[marcoR]

I'm not a script head, so.. these rules would not be worth remembering, nor practicing.

[protagonist]

Originally posted by Tseng


Neater? Subjective. I find it neater to have a balance of lines and lengths. You find it neater to have one check per line. When they are related (as they are in this case), I find it unnecessary to split it up. Perhaps I should paste the first line of the first if check in the hpfunctions subroutine on graal2001, and ask if those shouldn't be split up.

One line of two related checks (an event and a condition) and splitting them up one to each line is the same code - so you can't really argue efficiency or optimization, but only a stylistic choice.

(Additionally, the standards thread does not mention putting an event and a condition on separate lines.

I also find it more efficient to have one check per line in MOST cases. It adds flexibility to a script. You can add in additional commands and statements very easily as compared to having multiple checks in your if statement.

[osrs]

Originally posted by Riot-Starter

I think it is only showcharacters, I just remember problems with gralats causing spar room doors to stay closed.
Although there is an easy fix to determine whether it’s an NPC or player.

Yep,also these new gralats are showcharacters =p

[Dach]

Originally posted by protagonist


I also find it more efficient to have one check per line in MOST cases

that's not more efficient, it's just your style. dang, that word is getting thrown around to often nowadays

[KainDaMan]

you can solve the problem of it counting npc characters by doing a for statement that includes the playerscount and a check if players[i].id>=0; as -1 = npc character. then if it's true add to a variable. this, however, would require resetting the string every time the event is called. I would go right out and post the script, but I fear it is against the rules of the NPC Scripting Forums

[Tseng]

Originally posted by protagonist


I also find it more efficient to have one check per line in MOST cases. It adds flexibility to a script. You can add in additional commands and statements very easily as compared to having multiple checks in your if statement.

Um, the first 'check' is when the action is called, so that happens regardless. The second 'check', be it on another line or in the same if ( ) statement, will be executed regardless; efficiency is not something you can debate with this.

Very easily? I don't go around putting '&& otherflag==true' for every check I add, but it is arguably easier to type two ampersands than 'if ( ) { }'. That does not make it better, but you are incorrect in saying it's easier.

[Kaimetsu]

It depends on Graal's inner workings. If you're using a literal compiler/interpreter that doesn't make a distinction between & and && then it's more efficient to split up the checks - if you combine them then it'll happily evaluate the whole condition without stopping to check if it's already invalidated itself.

[Tseng]

Originally posted by Kaimetsu
It depends on Graal's inner workings. If you're using a literal compiler/interpreter that doesn't make a distinction between & and && then it's more efficient to split up the checks - if you combine them then it'll happily evaluate the whole condition without stopping to check if it's already invalidated itself.

Well, I think I said it before, but I am only talking about an:

if (event && flag=true) {

compared to:

if (event) {
if (flag==true) {

type situation - if the event occurs, how could it invalidate itself in either?

Or, are you talking about if the event doesn't occur at all? That's the only way I can think that it could be invalidated...

[Kaimetsu]

Ah, yes, in that case you are correct. I tend to favour separation of event checks from normal conditional statements, but that's just a stylistic thing. Wouldn't affect efficiency.

[mhermher]

NPC Code:

---

//#CLIENTSIDE

if (timeout||playerenters) {

 if (playerscount=>5) {

 //Stuff here

 }

timeout=0.05;

}

---

Also note if you have showcharacter NPCS (the ones which stefan put in.. that have heads, bodies and stuff counts as players to, so if you got lets say 2 of them, change the 5 to 7.

[Snakeandy7]

//#CLIENTSIDE
if ((playerenters && strequals(#L,levelname.nw)) || timeout){
for(i=0; i<playerscount; i++{
stuff here :o
}
timeout=0.05;
}
Isnt that one way?
I dont think it is.. not sure tho :o..

[mhermher]

Snake, no need for the level thing, playerscount is the players in the level, allplayers is players in the server.

[Snakeandy7]

I see, Thanks for mensioning

[KainDaMan]

the npc character's problem can be solved like this

NPC Code:

---

for (i=0; i<playerscount; i++) {

  if (players[i].id>=0) {

    this.players++;

  }

}

---

of course the "this.players" variable would have to be reset to zero before called. and the variable "this.players" everytime would equal to the amount of "real players" in the room.

[protagonist]

Originally posted by Tseng


Um, the first 'check' is when the action is called, so that happens regardless. The second 'check', be it on another line or in the same if ( ) statement, will be executed regardless; efficiency is not something you can debate with this.

Very easily? I don't go around putting '&& otherflag==true' for every check I add, but it is arguably easier to type two ampersands than 'if ( ) { }'. That does not make it better, but you are incorrect in saying it's easier.

It seems bluntly obvious that it is in the interest of readability to seperate your conditional checks.

[Tseng]

Originally posted by protagonist


It seems bluntly obvious that it is in the interest of readability to seperate your conditional checks.

What part of 'stylistic choice' don't you understand? Readability is subjective.

[Dach]

I prefer Tsengs way actually, because if you ask me its alot easier to see all the checks at once instead of making new brackets for each one

just so you know it's not jut Tseng whose crazy

[Tseng]

Originally posted by Dach
I prefer Tsengs way actually, because if you ask me its alot easier to see all the checks at once instead of making new brackets for each one

just so you know it's not jut Tseng whose crazy

Well, you can liken it to reading. Different cultures have come up with different ways to read books. Some go left to right, then up to down; others go right to left, up to down; others just go straight down, right to left; still others go in other ways. Can you argue that our style of reading is better than the Japanese, or Hebrew?

Stylistic. choice.