Buy System Help!

[Astram]

Class:

PHP Code:

//#CLIENTSIDE
function onActionLeftMouse() {
Buy_Window1.show();
  new GuiWindowCtrl("Buy_Window1") {
    profile = GuiBlueWindowProfile;
    clientrelative = true;
    clientextent = "320,240";

    canclose = false;
    canmaximize = false;
    canminimize = false;
    canmove = true;
    canresize = true;
    closequery = false;
    destroyonhide = false;
    text = "Buy This Item?";
    x = 509;
    y = 203;

    new GuiButtonCtrl("Buy_Button1") {
      profile = GuiBlueButtonProfile;
      text = "Buy Item";
      width = 80;
      x = 118;
      y = 133;
    }
    new GuiTextCtrl("Buy_Text1") {
      profile = GuiBlueTextProfile;
      height = 20;
      width = 8;
      x = 143;
      y = 9;
    }
    new GuiTextCtrl("Buy_Text2") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Would you like to buy?";
      width = 108;
      x = 106;
      y = 35;
    }
    new GuiTextCtrl("Buy_Text3") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = this.item;
      width = 39;
      x = 135;
      y = 51;
    }
    new GuiTextCtrl("Buy_Text4") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "For...";
      width = 25;
      x = 145;
      y = 66;
    }
    new GuiTextCtrl("Buy_Text5") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = this.price;
      width = 44;
      x = 132;
      y = 86;
    }
    new GuiButtonCtrl("Buy_Button2") {
      profile = GuiBlueButtonProfile;
      text = "No thank you.";
      width = 80;
      x = 118;
      y = 185;
    }
  }
  Buy_Window2.hide();
  new GuiWindowCtrl("Buy_Window2") {
    profile = GuiBlueWindowProfile;
    clientrelative = true;
    clientextent = "320,206";

    canclose = false;
    canmaximize = false;
    canminimize = false;
    canmove = true;
    canresize = true;
    closequery = false;
    destroyonhide = false;
    text = "Receipt";
    x = 853;
    y = 88;

    new GuiTextCtrl("Buy_Text6") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Item:";
      width = 22;
      x = 140;
      y = 24;
    }
    new GuiTextCtrl("Buy_Text7") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = this.item;
      width = 39;
      x = 131;
      y = 44;
    }
    new GuiTextCtrl("Buy_Text8") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Receipt";
      width = 36;
      x = 134;
    }
    new GuiTextCtrl("Buy_Text9") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Price:";
      width = 27;
      x = 135;
      y = 70;
    }
    new GuiTextCtrl("Buy_Text10") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = this.price;
      width = 44;
      x = 126;
      y = 92;
    }
    new GuiButtonCtrl("Buy_Button3") {
      profile = GuiBlueButtonProfile;
      height = 22;
      text = "Take My Item, I agree that I bought this item!";
      width = 320;
      y = 184;
    }
    new GuiTextCtrl("Buy_Text11") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Weapon Name:";
      width = 73;
      x = 115;
      y = 114;
    }
    new GuiTextCtrl("Buy_Text12") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = this.weapon;
      width = 60;
      x = 122;
      y = 141;
    }
    Buy_Window2.hide();
  }
}

function Buy_Button1.onAction() {
  Buy_Window1.hide();
  Buy_Window2.show();
}

function Buy_Button2.onAction() {
  Buy_Window1.hide();
}

function Buy_Button3.onAction() {
  Buy_Window2.hide();
  buy2(this.weapon, this.price, this.item);
} 


The public function buy2

PHP Code:

public function buy2(a, b, c)
{
a = temp.weapon;
b = temp.price;
c = temp.name;
player.rupees -= temp.price;
addweapon(temp.weapon);
player.chat = "I bought a "@temp.name@"! For "@temp.price@"!";
} 


The NPC

PHP Code:

join("object_buy");
//#CLIENTSIDE
function onCreated()
  {
  this.item = "Ghost";
  this.price = "2500";
  this.weapon = "Morphs/Ghost";
} 


What I need help with?
Whenever I use the system this.item, this.price, and this.weapon ALWAYS = 0 in the actual GUI when you use it! Now I dont really know how to get that to say the NPCs variables, please help!

[fowlplay4]

You have to use thiso. instead of just this because of where you're using the variables.

[Astram]

Originally Posted by fowlplay4

You have to use thiso. instead of just this because of where you're using the variables.

Thanks so much
I finally got it to work!!!

[fowlplay4]

Originally Posted by Astram

Just replace thiso with this, on ALL of the scripts above?

No, only in the sections where you try to set GUI text to "this." values.

Reason: this. when used in the scope of another object refers to that object, so you have to get the values from the origin "thiso." object.

If you look at the output you'll see what's going on.

PHP Code:

//#CLIENTSIDE
function onCreated() {
  this.example = "Hello World!";
  new GuiWindowCtrl("Example") {
    x = 0;
    y = 0;
    width = height = 200;

    // Check F2 Logs for Output
    echo("this.name: " @ this.name @ " this.example: " @ this.example);
    echo("thiso.name: " @ thiso.name @ " thiso.example: " @ thiso.example);

    text = thiso.example;
  }
} 


[Astram]

Do you know how to fix the problem when gralats go down then back up?
Like
player.rupees -= this.price;
The players rupees go down for .5 of a second then back up to the original rupees!

[fowlplay4]

Originally Posted by Astram

Do you know how to fix the problem when gralats go down then back up?
Like
player.rupees -= this.price;
The players rupees go down for .5 of a second then back up to the original rupees!

You have to change it on the server-side, not the client-side.

[Astram]

Is this the same as addweapon();?

[fowlplay4]

Originally Posted by Astram

Is this the same as addweapon();?

I guess they're same in the sense that you have to call them both on the server-side.

[Astram]

New Script Still Needs help, now it doesnt view the gui, and it hides on clicked. Nothing happens... I need major help...

Class:

PHP Code:

function onActionServerSide(cmd)
{
if (cmd == "buy")
{
player.rupees -= thiso.price;
addweapon(thiso.weapon);
}
}//#CLIENTSIDE
function onActionLeftMouse() {
Buy_Window1.show();
  new GuiWindowCtrl("Buy_Window1") {
    profile = GuiBlueWindowProfile;
    clientrelative = true;
    clientextent = "320,240";

    canclose = false;
    canmaximize = false;
    canminimize = false;
    canmove = true;
    canresize = true;
    closequery = false;
    destroyonhide = false;
    text = "Buy This Item?";
    x = 509;
    y = 203;

    new GuiButtonCtrl("Buy_Button1") {
      profile = GuiBlueButtonProfile;
      text = "Buy Item";
      width = 80;
      x = 118;
      y = 133;
    }
    new GuiTextCtrl("Buy_Text1") {
      profile = GuiBlueTextProfile;
      height = 20;
      width = 8;
      x = 143;
      y = 9;
    }
    new GuiTextCtrl("Buy_Text2") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Would you like to buy?";
      width = 108;
      x = 106;
      y = 35;
    }
    new GuiTextCtrl("Buy_Text3") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.item;
      width = 39;
      x = 135;
      y = 51;
    }
    new GuiTextCtrl("Buy_Text4") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "For...";
      width = 25;
      x = 145;
      y = 66;
    }
    new GuiTextCtrl("Buy_Text5") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.price;
      width = 44;
      x = 132;
      y = 86;
    }
    new GuiButtonCtrl("Buy_Button2") {
      profile = GuiBlueButtonProfile;
      text = "No thank you.";
      width = 80;
      x = 118;
      y = 185;
    }
  }
  new GuiWindowCtrl("Buy_Window2") {
    profile = GuiBlueWindowProfile;
    clientrelative = true;
    clientextent = "320,206";
    canclose = false;
    canmaximize = false;
    canminimize = false;
    canmove = true;
    canresize = true;
    closequery = false;
    destroyonhide = false;
    text = "Receipt";
    x = 853;
    y = 88;

    new GuiTextCtrl("Buy_Text6") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Item:";
      width = 22;
      x = 140;
      y = 24;
    }
    new GuiTextCtrl("Buy_Text7") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.item;
      width = 39;
      x = 131;
      y = 44;
    }
    new GuiTextCtrl("Buy_Text8") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Receipt";
      width = 36;
      x = 134;
    }
    new GuiTextCtrl("Buy_Text9") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Price:";
      width = 27;
      x = 135;
      y = 70;
    }
    new GuiTextCtrl("Buy_Text10") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.price;
      width = 44;
      x = 126;
      y = 92;
    }
    new GuiButtonCtrl("Buy_Button3") {
      profile = GuiBlueButtonProfile;
      height = 22;
      text = "Take My Item, I agree that I bought this item!";
      width = 320;
      y = 184;
    }
    new GuiTextCtrl("Buy_Text11") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Weapon Name:";
      width = 73;
      x = 115;
      y = 114;
    }
    new GuiTextCtrl("Buy_Text12") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.weapon;
      width = 200;
      x = 122;
      y = 141;
    }
    Buy_Window2.hide();
  }
}

function Buy_Button1.onAction() {
  Buy_Window1.hide();
  Buy_Window2.show();
}

function Buy_Button2.onAction() {
  Buy_Window1.hide();
}

function Buy_Button3.onAction() {
  Buy_Window2.hide();
  triggerserver("gui",thiso.name,"buy");
  player.chat = "Bought "@thiso.item@"!";
} 


(deleted the public function buy2)...

NPC:

PHP Code:

join("object_buy");
//#CLIENTSIDE
function onCreated()
  {
  thiso.item = "Ghost";
  thiso.price = "2500";
  thiso.weapon = "Morphs/Ghost";
} 


Help... :o

[Astram]

OOPS LMAO!!!
I put...
} and //#CLIENTSIDE
on the same line... xD!

[Astram]

Originally Posted by Astram

OOPS LMAO!!!
I put...
} and //#CLIENTSIDE
on the same line... xD!

Though it still doesnt work when I corrected, the addweapon and subtracting the gralats

[fowlplay4]

The variables are only accessible on the client-side in your script above.

You can simply just place them on the server-side.

PHP Code:

join("object_buy");

function onCreated() 
{ 
  this.item = "Ghost"; 
  this.price = "2500"; 
  this.weapon = "Morphs/Ghost"; 
}

//#CLIENTSIDE

function onCreated() 
{ 
  this.item = "Ghost"; 
  this.price = "2500"; 
  this.weapon = "Morphs/Ghost"; 
} 


[Astram]

That Class still doesnt add the weapon and substract the gralats...
I tried your NPC as well...

[gwFCCtennis]

Originally Posted by Astram

That Class still doesnt add the weapon and substract the gralats...
I tried your NPC as well...

I think he was comparing the two scripts, showing not to do clientside, and the correct one to use was the top one which was

PHP Code:

join("object_buy"); 

function onCreated()  
{  
  this.item = "Ghost";  
  this.price = "2500";  
  this.weapon = "Morphs/Ghost";  
} 


[fowlplay4]

Originally Posted by Astram

That Class still doesnt add the weapon and substract the gralats...
I tried your NPC as well...

Right, well it doesn't work because you're trying to use triggerserver in a level npc.

[Mark Sir Link]

Originally Posted by fowlplay4

Right, well it doesn't work because you're trying to use triggerserver in a level npc.

Originally Posted by Astram

PHP Code:

function onActionServerSide(cmd)
{
if (cmd == "buy")
{
player.rupees -= thiso.price;
addweapon(thiso.weapon);
}
} 


thiso.price and thiso.weapon are undefined on the serverside, you need to use the params you are sending in triggerserver, you need to invoke the object for addweapon (player.addweapon())

You also really shouldn't define the weapon name and cost on the clientside since it opens it up for all sorts of abuse.

[fowlplay4]

Originally Posted by Mark Sir Link

thiso.price and thiso.weapon are undefined on the serverside, you need to use the params you are sending in triggerserver, you need to invoke the object for addweapon (player.addweapon())

You also really shouldn't define the weapon name and cost on the clientside since it opens it up for all sorts of abuse.

He says he's using a class and a level npc, therefore using triggerserver won't work for what he's trying to do.

Also there's no problem with defining it client-side (saves a trip for sending the data via triggerclient, attribute or similar), the problem comes into play when you're not validating it on the server-side or when you don't keep them in sync (the same).

So we can setup a weapon system to do this or use the simple triggeraction method which is a little more newbie friendly.

Syntax: triggeraction(x, y, actionName, param0, param1, [...])

x - The x coordinate to trigger
y - The y coordinate to trigger
actionName - The actionEvent to hit. I.e: Passing "Buy" will trigger onActionBuy on the server-side
param0, param1, ... - Parameter data/message to send to the server.

Example usage:

PHP Code:

function onCreated() {
  // Give the object shape on the server-side
  // This is very important or else the triggeraction won't "hit" it.
  this.setshape(1, 32, 32);
}

function onActionBuy() {
  // Check the ID passed
  // Prevents stacked NPCs from reacting to triggers that don't concern them.
  if (params[0] == this.id) {
    player.chat = "Bought an " @ params[1] @ "!";
  }
}

//#CLIENTSIDE

function onCreated() {
  this.chat = "Say '/buy' to execute this example!";
}

function onPlayerChats() {
  if (player.chat == "/buy") {
    // Sends a "Buy" trigger to the coordinates
    // this calls onActionBuy on both server and client sides.
    triggeraction(this.x + 1, this.y + 1, "Buy", this.id, "example"); 
  }
} 


[Astram]

Originally Posted by fowlplay4

Right, well it doesn't work because you're trying to use triggerserver in a level npc.

So then seriously what am I supposed to do...

[fowlplay4]

Originally Posted by Astram

So then seriously what am I supposed to do...

Read my last post, I clarified and showed you the alternative.

[cbk1994]

Suggestion: Have one DB NPC named something like "ShopControl" and trigger that using triggerserver. Triggering serverside to level NPCs is a pain in the ass.

[Astram]

Originally Posted by cbk1994

Suggestion: Have one DB NPC named something like "ShopControl" and trigger that using triggerserver. Triggering serverside to level NPCs is a pain in the ass.

I'm not to familiar with DB NPCs...

[Astram]

I still dont understand x_X

[fowlplay4]

Triggering a DB-NPC with triggerserver.

DB-NPC (The dragon button): ShopControl

PHP Code:

function onActionServerSide() {
  sendtorc(params[0] SPC "and" SPC params[1]);
} 


Level NPC:

PHP Code:

//#CLIENTSIDE
function onCreated() {
  triggerserver("npc", "ShopControl", "hey now!", "bababooey to you all");
} 


[Astram]

Originally Posted by fowlplay4

Triggering a DB-NPC with triggerserver.

DB-NPC (The dragon button): ShopControl

PHP Code:

function onActionServerSide() {
  sendtorc(params[0] SPC "and" SPC params[1]);
} 


Level NPC:

PHP Code:

//#CLIENTSIDE
function onCreated() {
  triggerserver("npc", "ShopControl", "hey now!", "bababooey to you all");
} 


Idk how to use params.. 0.0 sorry im kind of a >>><<< at scripting...

[fowlplay4]

Originally Posted by Astram

Idk how to use params.. 0.0 sorry im kind of a >>><<< at scripting...

Play with the examples I've provided, I'm not sure how I can make it any clearer for you without just making the script for you.

[cbk1994]

Originally Posted by Astram

Idk how to use params.. 0.0 sorry im kind of a >>><<< at scripting...

Parameters are passed to a function.

PHP Code:

function onCreated() {
  this.myFunction("bob", "hello there");
}

function myFunction() {
  player.chat = params[0] @ " says " @ params[1];
} 


params is an array that you can use to see what data was given to the function. This makes it possible to use functions for many things.

Instead of using the params array, you should usually assign parameters a name, like so:

PHP Code:

function myFunction(person, msg) {
  player.chat = person @ " says " @ msg;
} 


[Astram]

Originally Posted by cbk1994

Parameters are passed to a function.

PHP Code:

function onCreated() {
  this.myFunction("bob", "hello there");
}

function myFunction() {
  player.chat = params[0] @ " says " @ params[1];
} 


params is an array that you can use to see what data was given to the function. This makes it possible to use functions for many things.

Instead of using the params array, you should usually assign parameters a name, like so:

PHP Code:

function myFunction(person, msg) {
  player.chat = person @ " says " @ msg;
} 


This is helpful, thanks chris Im going to see what I can do, hopefully I complete my misson of creating this!

[Astram]

Okay so I have this and it seems to be working, other then the part that the DB NPC only supports the item name custom to the script, I tried thiso.weapon for a, and thiso.price for b.

Current DB NPC: "Buy"

PHP Code:

function onActionServerSide(cmd)
{
if (cmd == "buy")
{
purchase("Morphs/Ghost", "2500");
}
}
function Purchase(a, b)
{
addweapon(a);
player.rupees -= b;
} 


Class:

PHP Code:

function onActionServerSide(cmd)
{
if (cmd == "buy")
{
player.rupees -= thiso.price;
addweapon(thiso.weapon);
}
}
//#CLIENTSIDE
function onActionLeftMouse() {
Buy_Window1.show();
  new GuiWindowCtrl("Buy_Window1") {
    profile = GuiBlueWindowProfile;
    clientrelative = true;
    clientextent = "320,240";

    canclose = false;
    canmaximize = false;
    canminimize = false;
    canmove = true;
    canresize = true;
    closequery = false;
    destroyonhide = false;
    text = "Buy This Item?";
    x = 509;
    y = 203;

    new GuiButtonCtrl("Buy_Button1") {
      profile = GuiBlueButtonProfile;
      text = "Buy Item";
      width = 80;
      x = 118;
      y = 133;
    }
    new GuiTextCtrl("Buy_Text1") {
      profile = GuiBlueTextProfile;
      height = 20;
      width = 8;
      x = 143;
      y = 9;
    }
    new GuiTextCtrl("Buy_Text2") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Would you like to buy?";
      width = 108;
      x = 106;
      y = 35;
    }
    new GuiTextCtrl("Buy_Text3") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.item;
      width = 39;
      x = 135;
      y = 51;
    }
    new GuiTextCtrl("Buy_Text4") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "For...";
      width = 25;
      x = 145;
      y = 66;
    }
    new GuiTextCtrl("Buy_Text5") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.price;
      width = 44;
      x = 132;
      y = 86;
    }
    new GuiButtonCtrl("Buy_Button2") {
      profile = GuiBlueButtonProfile;
      text = "No thank you.";
      width = 80;
      x = 118;
      y = 185;
    }
  }
  new GuiWindowCtrl("Buy_Window2") {
    profile = GuiBlueWindowProfile;
    clientrelative = true;
    clientextent = "320,206";
    canclose = false;
    canmaximize = false;
    canminimize = false;
    canmove = true;
    canresize = true;
    closequery = false;
    destroyonhide = false;
    text = "Receipt";
    x = 853;
    y = 88;

    new GuiTextCtrl("Buy_Text6") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Item:";
      width = 22;
      x = 140;
      y = 24;
    }
    new GuiTextCtrl("Buy_Text7") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.item;
      width = 39;
      x = 131;
      y = 44;
    }
    new GuiTextCtrl("Buy_Text8") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Receipt";
      width = 36;
      x = 134;
    }
    new GuiTextCtrl("Buy_Text9") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Price:";
      width = 27;
      x = 135;
      y = 70;
    }
    new GuiTextCtrl("Buy_Text10") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.price;
      width = 44;
      x = 126;
      y = 92;
    }
    new GuiButtonCtrl("Buy_Button3") {
      profile = GuiBlueButtonProfile;
      height = 22;
      text = "Take My Item, I agree that I bought this item!";
      width = 320;
      y = 184;
    }
    new GuiTextCtrl("Buy_Text11") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = "Weapon Name:";
      width = 73;
      x = 115;
      y = 114;
    }
    new GuiTextCtrl("Buy_Text12") {
      profile = GuiBlueTextProfile;
      height = 20;
      text = thiso.weapon;
      width = 200;
      x = 122;
      y = 141;
    }
    Buy_Window2.hide();
  }
}

function Buy_Button1.onAction() {
  Buy_Window1.hide();
  Buy_Window2.show();
}

function Buy_Button2.onAction() {
  Buy_Window1.hide();
}

function Buy_Button3.onAction() {
  Buy_Window2.hide();
triggerserver("npc","Buy","buy");
  player.chat = "Bought "@thiso.item@"!";
} 


NPC:

PHP Code:

join("object_buy");

function onCreated()
{
thiso.item = "Ghost";
thiso.price = "2500";
thiso.weapon = "Morphs/Ghost";
}

//#CLIENTSIDE

function onCreated()
{
thiso.item = "Ghost";
thiso.price = "2500";
thiso.weapon = "Morphs/Ghost";
} 


Help :0 seems like only the DB NPC needs work

[salesman]

Originally Posted by Astram

snip

Take a look at this line:

PHP Code:

triggerserver("npc","Buy","buy"); 


and you should be able to figure your problem out. (or at least one of them =p)

[Astram]

Originally Posted by salesman

Take a look at this line:

PHP Code:

triggerserver("npc","Buy","buy"); 


and you should be able to figure your problem out. (or at least one of them =p)

I seriously dont notice?
NPC, DBNPC Name, param...
Should I include thiso.weapon, and thiso.price?

[cbk1994]

Add an echo into the onActionSeverSide event in the DB NPC and see if the trigger is being received.

[Astram]

Originally Posted by cbk1994

Add an echo into the onActionSeverSide event in the DB NPC and see if the trigger is being received.

Yes the trigger is recived... Though, the script doesnt work...

PHP Code:

function onActionServerSide(cmd)
{
if (cmd == "buy")
{
purchase(thiso.weapon, thiso.price);
}
}
function Purchase(a, b)
{
addweapon(a);
player.rupees -= b;
} 


[salesman]

Originally Posted by Astram

I seriously dont notice?
NPC, DBNPC Name, param...
Should I include thiso.weapon, and thiso.price?

My bad, I misread and thought you weren't catching the trigger inside the Buy NPC.

[cbk1994]

The problem is that the weapon and the price aren't defined. You'll need to have the client send information on the weapon when it sends the trigger. You could also have it send the price but that's a security risk.

My suggestion (since I doubt you want to use NPC registration, which is what I would do) is to have a list of prices for each weapon:

PHP Code:

function onCreated() {
  this.price.Sword = 100;
}

function onActionServerSide(cmd, item) {
  if (cmd == "buy") {
    if (this.price.(@ item) > 0) {
      if (player.rupees > this.price.(@ item)) {
        player.rupees -= this.price.(@ item);
        player.addWeapon(item);
      } else {
        player.chat = "I don't have enough money to buy this item!";
      }
    }
  }
}