Joining classes first

[cbk1994]

There's an annoying delay between the time the onActionPlayerOnline function in the Control-NPC is called and when the classes are joined. That, or the level NPCs are called first (onPlayerEnters).

The problem is that this kind of thing happens in level NPCs that have an onPlayerEnters() function:

Originally Posted by NC

Script: Function cbk1994.onStaffTag not found at line 7 of jail_level in script of npcs[16] (in level era_jail.nw at pos (29, 36))
Script: Function cbk1994.isStaff not found at line 7 of jail_level in script of npcs[16] (in level era_jail.nw at pos (29, 36))
Script: Function cbk1994.unstick not found at line 8 of jail_level in script of npcs[16] (in level era_jail.nw at pos (29, 36))

This is the onActionPlayerOnline function.

PHP Code:

function onActionPlayerOnline() {
  if (! (player.account in serveroptions.staff.tokenize(","))) {
    player.addWeapon("Temp/Server Warp");
    return; // goodbye, global news team
  }
  
  clientr.serversideReady = false;
  
  player.join("player_itemfunctions");
  player.join("player");
  player.join("player_staff");
  player.join("player_hpfunctions");
  
  player.loadPlayer();
} 


As you can see, the player class is being joined almost at once.

I think that the server should wait up to five seconds for onActionPlayerOnline to complete and for all of the classes to join, and then trigger onPlayerEnters to level NPCs. This could also be extended to weapons so that they are not called before their items and such have been loaded.

[DustyPorViva]

Also clientside callstack, please?

[cbk1994]

Bump because I can't stress how important this is.

[xXziroXx]

I added something like this on Maloria a while back, since I too was annoyed by it, and thought this might solve it. Note that it didn't.

PHP Code:

function onActionPlayerOnline()
{
  // --- JOINING OF CLASSES
  temp.class_list = {
    "functions_misc",
    "functions_stats",
    "functions_skills",
    "functions_items",
    "functions_combat",
    "functions_nations",
    "player_system",
    "player_initialize",
    "quest_log"
  };
  while (!temp.isJoined) {
    temp.isJoined = true;
    temp.attempts ++;
    
    for (temp.class: temp.class_list) {
      player.join(temp.class);
      if (!(temp.class in player.joinedclasses))
        temp.isJoined = false;
    }
  }
  if (temp.attempts > 1)
    echo("[" @ player.account @ "] All classes joined after" SPC temp.attempts SPC "attempts!");
} 


I still get errors whenever the client enters a level that might use a function that's supposed to be joined to a player.

[Admins]

Hmmm it could be possible to force the onActionPlayerOnline to execute immediatelly at login, need to check this.

[cbk1994]

Originally Posted by Stefan

Hmmm it could be possible to force the onActionPlayerOnline to execute immediatelly at login, need to check this.

That would be absolutely wonderful.




sorry stefan

[xXziroXx]

Originally Posted by Stefan

Hmmm it could be possible to force the onActionPlayerOnline to execute immediatelly at login, need to check this.

Would be very awesome.

[Admins]

Has Classic staff already tested if it's working fine?

[ffcmike]

Originally Posted by Stefan

Has Classic staff already tested if it's working fine?

Just tested now,
a player class function is definately working straight after player.join("class"); in ActionPlayerOnline, and not before it (if I remember correctly player classes are no longer joined to the player object once they log out),
levels with scripts that call a player class function on entry aren't causing errors after logging in,
so I believe this is working.

[Skyld]

Originally Posted by cbk1994

There's an annoying delay between the time the onActionPlayerOnline function in the Control-NPC is called and when the classes are joined. That, or the level NPCs are called first (onPlayerEnters).

The problem is that this kind of thing happens in level NPCs that have an onPlayerEnters() function:



This is the onActionPlayerOnline function.

PHP Code:

function onActionPlayerOnline() {
  if (! (player.account in serveroptions.staff.tokenize(","))) {
    player.addWeapon("Temp/Server Warp");
    return; // goodbye, global news team
  }
  
  clientr.serversideReady = false;
  
  player.join("player_itemfunctions");
  player.join("player");
  player.join("player_staff");
  player.join("player_hpfunctions");
  
  player.loadPlayer();
} 


As you can see, the player class is being joined almost at once.

I think that the server should wait up to five seconds for onActionPlayerOnline to complete and for all of the classes to join, and then trigger onPlayerEnters to level NPCs. This could also be extended to weapons so that they are not called before their items and such have been loaded.

Hmm you can't put the loadPlayer() stuff in the onCreated() class of the last joined class? I do this on Rudora and it works fine, since onCreated() is called in the class when it is joined to the player.

[cbk1994]

Originally Posted by Skyld

Hmm you can't put the loadPlayer() stuff in the onCreated() class of the last joined class? I do this on Rudora and it works fine, since onCreated() is called in the class when it is joined to the player.

I'm sure that would work just as well, but there is no advantage to it, and it would not solve this problem; loadPlayer() is only loading their items, not adding any functions.


Glad to hear that this is working on Classic, hopefully this can be enabled soon for other servers.

[cbk1994]

Any ETA for other servers? I haven't noticed this in a while, though, so perhaps it's already been done?

[Admins]

It has not been enabled yet on other servers but can be done soon.

[xXziroXx]

Originally Posted by Stefan

It has not been enabled yet on other servers but can be done soon.

I beg of you, hurry!

[ffcmike]

I'm getting a similar issue except with classes that are joined to the player clientside, it had been working fine for myself, but then I realised there was a large delay involved before the player functions could be called by players with a slow connection/high ping, which is understandable, but something which could cause alot of problems.

Any possibility this could be rectified in the next client version?

[cbk1994]

Originally Posted by ffcmike

I'm getting a similar issue except with classes that are joined to the player clientside, it had been working fine for myself, but then I realised there was a large delay involved before the player functions could be called by players with a slow connection/high ping, which is understandable, but something which could cause alot of problems.

Any possibility this could be rectified in the next client version?

There's really no way to fix this. I'd recommend having some kind of "player.isReady" variable (clientside), and set that to true once the class is loaded.

[ffcmike]

I've done some experimenting with the joinedclasses variable, seems the class names immediately get added before the class has actually loaded, and I can't seem to get any type of success with the onClassLoaded function, whether it be within a weapon or the class script itself, same for onCreated within the clientside class script, they just don't seem to occur, otherwise that's probably what I would do.

[cbk1994]

Originally Posted by ffcmike

I've done some experimenting with the joinedclasses variable, seems the class names immediately get added before the class has actually loaded, and I can't seem to get any type of success with the onClassLoaded function, whether it be within a weapon or the class script itself, same for onCreated within the clientside class script, they just don't seem to occur, otherwise that's probably what I would do.

An onCreated() event in the class clientside should be okay.

[ffcmike]

Originally Posted by cbk1994

An onCreated() event in the class clientside should be okay.

I've read that it should work before, but it doesn't, not sure if this is something specific to Classic or having the same class joined to the player serverside affects it.

Totally forgot I could just do player.hasfunction(""); though.