Math!

[excaliber7388]

Hmm, what's wrong with these? Addition is the same way, and works fine, but none of these work x_X (the reason for the temp.display is to make the display flash, but still save the date for the block)

PHP Code:

function calc_subtract.onAction()
{
  temp.display=calc_num.text;
  calc_num.text="";
  sleep .05;
  calc_num.text=temp.display;
  sleep .05;
  calc_num.text="";
  this.total-=temp.display;
    this.calc_mode=2;
}
function calc_multiply.onAction()
{
  temp.display=calc_num.text;
  calc_num.text="";
  sleep .05;
  calc_num.text=temp.display;
  sleep .05;
  calc_num.text="";
  this.total*=temp.display;
    this.calc_mode=3;
}
function calc_divide.onAction()
{
  temp.display=calc_num.text;
  calc_num.text="";
  sleep .05;
  calc_num.text=temp.display;
  sleep .05;
  calc_num.text="";
  this.total/=temp.display;
  this.calc_mode=4;
} 


[Skyld]

Why use sleep?

[excaliber7388]

Originally Posted by Skyld

Why use sleep?

It's to make the display 'blip' like a calculator does

[Tyrial]

Originally Posted by excaliber7388

It's to make the display 'blip' like a calculator does

Use a timeout loop instead..

Edit:

If it's going to blip only a certain times, use a for loop.

[excaliber7388]

I don't think the blip is contributing to the math errors. For example, 8-6 is not -14, however, that's what's showing up

[Shaun]

It would be useful to see the rest of the algorithm in trying to come to a solution.

EDIT:

And those are GS1 sleeps, not GS2

[excaliber7388]

Originally Posted by Shaun

It would be useful to see the rest of the algorithm in trying to come to a solution.

EDIT:

And those are GS1 sleeps, not GS2

Good point XD
Since they're all the same (and none but addition work):

PHP Code:

  temp.display=calc_num.text;
  calc_num.text="";
  this.total-=temp.display;
    this.calc_mode=2; 


as for the equals button:

PHP Code:

if(this.calc_mode==2)
  {
    this.total-=calc_num.text;
  } 


[Admins]

The script looks ok, but the rest of the script which you have not shown might make problems, e.g. when calling setTimer(time) or setting timeout = time then 'sleeps' are stopped. You could eventually use scheduleevent(delay,action,params)

[ApothiX]

This may be a problem with what 'this.total' contains before/after you hit the subtraction sign.

[Tolnaftate2004]

Originally Posted by excaliber7388

PHP Code:

function calc_subtract.onAction()
{
  // stuff
  this.total-=temp.display;
  // stuff
}
function calc_multiply.onAction()
{
  // stuff
  this.total*=temp.display;
  // stuff
}
function calc_divide.onAction()
{
  // stuff
  this.total/=temp.display;
  // stuff
} 


I can't be sure, but it seems to me that the probem lies in these actions. I am supposing that these are to set the first number. In which case,

NPC Code:

---

this.total-=temp.display

this.total*=temp.display

this.total/=temp.display

---

should be

NPC Code:

---

this.total = temp.display

---

It seems to me what you are actually doing is
0 + 8 + 6 = 14 <- is correct
0 - 8 - 6 = -14
0 * 8 * 6 = 0
0 / 8 / 6 = 0