Simple Chat-Based Bank

[killerogue]

Hey! I've been learning to script lately, and Twinny asked me to make a bank. So I've been working on this for about 30 mins or so with a bit of help from Twinny and some from PFA.

Not exactly working out.

The general idea is to open the account, deposit, withdraw or close the account all with chat.

PHP Code:

function onActionserverside() {

  if (params[0] == "open") {
    Test.(@"account_" @ player.account) += params[1];

}

  else if (params[0] == "deposit") {
    Test.(@"account_" @ player.account) += params[1];

}
 
  else if (params[0] == "withdraw") {
    Test.(@"account_" @ player.account) -= params[1];
 
  }
}
  
//#CLIENTSIDE
function onPlayerchats() {
  
  if (player.chat == "/openbankaccount") {
    if(player.gralats > 300) {
      player.gralats - 300;
      this.startmoney = 300;
      triggeraction(0,0,"serverside",this.name,"open",this.startmoney);
  }
}

  else if (player.chat == "/closebankaccount") {
    Test.(@"account_" @ player.account).clear();

}

  else if (player.chat.starts("/deposit")) {
    this.depmoney = player.chat.substring(10);
    triggeraction(0,0,"serverside",this.name,"deposit",this.depmoney);

}

  else if (player.chat.starts("/withdraw")) {
    this.witmoney = player.chat.substring(11);
    triggeraction(0,0,"serverside",this.name,"withdraw",this.witmoney);

  }
} 


[contiga]

Test.( @ "account_" @ player.account).clear(); should be on the serverside, player.gralats should be player.rupees and should be moved to the serverside also.

[Riot]

Originally Posted by contiga

player.gralats should be player.rupees and should be moved to the serverside also.

The wiki and scriptfunctions_client.txt state to use 'gralats' instead of 'rupees':
rupees - integer - better use 'gralats'

You should throw as much as this in the serverside as possible, if not all of it.

[Angel_Light]

instead of player.gralats/rupees use a clientr.var much better in my opnions. ^-^

[killerogue]

Originally Posted by Angel_Light

instead of player.gralats/rupees use a clientr.var much better in my opnions. ^-^

Not sure how to use clientr.

[Rapidwolve]

replace player. with clientr.
to start off

[Twinny]

Originally Posted by Angel_Light

instead of player.gralats/rupees use a clientr.var much better in my opnions. ^-^

Depends if the rest of his systems use player.gralats.... could be a nasty change .

[napo_p2p]

Originally Posted by Twinny

Depends if the rest of his systems use player.gralats.... could be a nasty change .

Could download all the .txt/.nw files then do a mass find/replace I guess.

But sometimes player.rupees are desirable b/c writes to it are really easy to log.

[Twinny]

Originally Posted by napo_p2p

But sometimes player.rupees are desirable b/c writes to it are really easy to log.

As soon as Stefan takes heed to my suggestion and brings protected vars, to hell with player.gralats!