How do YOU style it?

[xXziroXx]

Ive been curious about whats the most common styling with using true/false variables, so I figured Id make a poll about it.



Alternative A:

PHP Code:

if (this.var == true)
if (this.var == false) 


Alternative B:

PHP Code:

if (this.var)
if (!this.var) 


I, personally, go with alternative A.

[Gambet]

I actually just style it depending on how I feel like doing it.

But, mostly, I believe I do Alternative B, though sometimes I do stuff like

PHP Code:

if (!(this.var)) 


[JkWhoSaysNi]

B...

Why check a boolean variable is true and then have the if statement check the result of that?

B just seems more efficient.

[Tolnaftate2004]

Originally Posted by JkWhoSaysNi

B...

Why check a boolean variable is true and then have the if statement check the result of that?

B just seems more efficient.

Ditto.

I also like to do stuff like

PHP Code:

temp.p = string.pos(substr);
if (~temp.p)
if (!~temp.p) 


[_Z3phyr_]

Personally I'm a fan of the cutoff look

[Chandler]

Option B

[DrakilorP2P]

I tend to go with B, especially when the variable name makes sense, such as this.pathIsBlocked.

[xXziroXx]

Haha, im totally in a minority here..

[Chompy]

Originally Posted by DrakilorP2P

I tend to go with B, especially when the variable name makes sense, such as this.pathIsBlocked.

agreed

[Crow]

Didnt vote for anything because of...

PHP Code:

if (this.var == 1)
if (this.var != 1) 


[godofwarares]

I prefer alternative A, because you find things better and its more comprehensive =]

[Skyld]

I normally use (and prefer to use) B, since there is little point in the engine essentially doing (var == true) == true, not sure if it's folded in the bytecode.

I do use A sometimes, though.

[Admins]

I prefer B, I think A comes from C++ where it sometimes looks better when you show that you make a boolean comparison and not some check-for-valid-pointer hack.
A is also slower although the comparions-operation is not really that slow. It looks a little bit weird to compare with true or false though, "if (true==true)"

[godofwarares]

Originally Posted by Stefan

I prefer B, I think A comes from C++ where it sometimes looks better when you show that you make a boolean comparison and not some check-for-valid-pointer hack.
A is also slower although the comparions-operation is not really that slow. It looks a little bit weird to compare with true or false though, "if (true==true)"

That would be a bit wierd, I always use while / if (true); So I suppose I alternate between A and B =]

[Inverness]

I prefer A since I like the way it looks.

[Andy0687]

I prefer method A.

However recently I found myself using method B because there is a bit less to type.