trader

[falco10291029]

I made a token(the money used on my server) trader, using with and crap as shown:

NPC Code:

---

if (actionserverside) {

  with(getplayer(#p(1))) {

    setstring client.tokens,#v(strtofloat(#s(client.tokens))+str  tofloat(#p(0)));

}

}

//#CLIENTSIDE

 if (playerchats&&startswith(token,#c)) {

  tokenize #c;

   play bomb.wav;//just to tell the person the transaction is done

  setstring client.tokens,#v(strtofloat(#s(client.tokens))-strtofloat(#t(1)));

 triggeraction 0,0,serverside,Token trader,#t(1),#t(2);

}

---

But foir some reason, the person supposedly recieving the tokens doesnt get them. Can someone help me? (Note: I am not asking for someone to fix it for me, just tell me what i am doing wrong so I can learn that for future reference)

[osrs]

If you say token osrs 1; It will get the account of the player instead of the value to be transfered. Maybe that is your problem, you may be using the wrong syntax when saying the commands. Make sure that the token #t(1) is a number and it is > 0.
Also I would suggest you to use a clientr.string, since client.strings are hackables.

[falco10291029]

I have tried the syntax thing and it didnt work and i already changed it so it must be a number over 0, and what makes clientr.string less hackable?

[Ningnong]

Thats not formatted according to correct coding standards :/

NPC Code:

---

if (playerchats){

  if (startswith(....

---

Also with that trading system you could say a minus value, which would give the player money.

i.e. trade -10 --- > current_tokens - -10 = +10

[falco10291029]

why does the coding standards matter? and why would i use negative amounts? Im getting little help here...

[Xecutor]

You won't necessarily say negative values, but a player would use it as a bug to gain money.

Coding standards matter to keep a level of efficiency.

[falco10291029]

i Could just abs it and also i could care less about level of efficiency i just want it to work!

[Xecutor]

Unefficient coding doesn't work all the time. It works when it wants to.

[Loriel]

"just getting it to work" is what killed Zone...

[Ningnong]

Also, you will need to include the players 'tokens' in that triggeraction (sending it to the server) using #s(client.tokens).

[falco10291029]

erm well it works fine normally it's not like i did something backwards like
if (keydown(132)) {if (timeout) {blahdeeblah}}
lol
now can someone just help me figure out what is wrong with this script?!

[Trevor]

Wouldn't you want the sound after the triggeraction? The "transaction" isn't done untill control is returned to clientside. (Well, I guess if Graal just sends out a triggeraction and doesn't wait for a response to continue executing scripts it doesn't matter much.)

This is more of a question on my part, but is a #s in a strtofloat() call really nessecary? It seems rather redundant :\ .

[Loriel]

Triggeraction is not waiting for the action to be received.

#s is neccessary.

[falco10291029]

Uh yeah so telll me, how does this help me?! Doesnt anyone here have the ability to find out what is wrong with the script that stops it from giving the other person tokens, and telling me?!
I dont care about format, or anything lelse about it, I'll be happy if it just works like i want it to !!!!!!!

[Loriel]

Yes, but we will not "be happy if it just works fine like you want it to !!!!!!! "
So if you request help, you should as well listen to suggestions and not ignore them.

[falco10291029]

i dont see why anyone else would care if its not formatted right or i dont use the right font size or whatever, since people who use the script wont be able to acess it. I do listen to suggestions but i ignore stuff like format it right because i dont care about that!

[Xecutor]

This forum is not made to just give you the answer, improper coding is not supported here. If you ignore the suggestions then you shouldn't bother asking at all.

[Loriel]

Exactly. I do not need to type ten characters. *waves hand*

[falco10291029]

*restrains self* look, all i want is a little help on my npc, if you guys cant help me with what i asked, then please stop posting

[Loriel]

Okay, I stopped the posting.