Thread: Feedback System
View Single Post
  #3  
Old 08-02-2011, 12:15 PM
cbk1994 cbk1994 is offline
the fake one
cbk1994's Avatar
Join Date: Mar 2003
Location: San Francisco
Posts: 10,718
cbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond reputecbk1994 has a reputation beyond repute
Send a message via AIM to cbk1994
The biggest problem with your script is that it's not formatted consistently. The second biggest is that you're using a checkbox instead of a button (I understand you want to 'challenge' yourself, but it's terrible to do that from a UI perspective).

Also note:
  • There's no reason to hide every object since they're all children of the window. Feedback_Test_Window2.hide(); will suffice.
  • There's no reason to send two triggers. Just send the value (whether they liked it or not) as a parameter.
  • I'm not quite sure why you're using a server variable at all. Even if you do it with two triggers, a player. or player.clientr. variable would work fine.
  • Make sure that the player has not already sent feedback on serverside to prevent hackers from voting infinite times.
  • Not sure why you have sleep 100;, but that should be sleep(100);
  • Give your GUI objects meaningful names. Feedback_Cancel is a better name than Feedback_Test_Button2.
__________________
Reply With Quote