Hmm, there's a lot of room for improvement. Props for the "ding dong do" comment, i loved that.
As for your outlining...there could be a lot more flare in it, don't just stick to the shapes as you know them, especially in something as versatile as a sword

Shading, listen to those above, get a source of light and shade accordingly.