Thread: GUI Tool
View Single Post
  #18  
Old 03-30-2008, 02:27 AM
Chompy Chompy is offline
¯\(º_o)/¯
Chompy's Avatar
Join Date: Sep 2006
Location: Norway
Posts: 2,815
Chompy is just really niceChompy is just really niceChompy is just really nice
Send a message via MSN to Chompy
Hmm, I decided to read over your script, and came across a few things.

1.

PHP Code:
Line  984showPoly( -player.account, {player.xplayer.yplayer.3player.y}); 
Why do you use player.account?


2.

Line 1019: say2() -> use of #b, that's gs1


3.

Line 1089: "if (timeout && this.ison == true) {", should be
PHP Code:
function onTimeout() {
  if (
this.ison == true) { // or just 'if (this.ison) {'
    
...
  }


4.

Stuff like player.ap, player.fullhearts etc. should be set serverside.


5.

Line 12: Space between function and parenthesis


6.

Line 19: "if (temp.Online = true) {" -> use '=='
And it could even just be
PHP Code:
if (temp.Online) {
  ...


7.

On a server like Unholy Nation I don't think a global say2 command for staff is needed, nor any fun for a player, f.ex durring pk or sparring


8.

Line 339 & 339: Use of object.level should be object.level.name


9.

Line 688: 0.05 is the smallest a timeout can be clientside, 0.1 serverside



Just some stuff I found, hope this can improve your script !
__________________
Reply With Quote