View Single Post
  #2  
Old 04-04-2007, 08:46 PM
Skyld Skyld is offline
Script-fu
Skyld's Avatar
Join Date: Jan 2002
Location: United Kingdom
Posts: 3,914
Skyld has much to be proud ofSkyld has much to be proud ofSkyld has much to be proud ofSkyld has much to be proud ofSkyld has much to be proud ofSkyld has much to be proud of
Send a message via AIM to Skyld
Just at a quick glance:
PHP Code:
   if (!this.cloner_on)
    {
     
this.cloner_on true;
     
player.chat "Outfit Cloner: On";
    }
   else
    {
     
this.cloner_on false;
     
player.chat "Outfit Cloner: Off";
    } 
... had might as well be:
PHP Code:
this.cloner_on = !this.cloner_on;
player.chat "Outfit Cloner: " @ (this.cloner_on "On" "Off"); 
Also.
PHP Code:
       for (pplayers)
        {
         for (
nnpcs)
          { 
Do you need to scan every NPC for every player? Can't you just scan them once?

Finally, can't you prefix your temp vars with temp.?
__________________
Skyld
Reply With Quote