Graal Forums - Something Easy probably

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - Something Easy probably (https://forums.graalonline.com/forums/showthread.php?t=87864)

Something Easy probably

PHP Code:


		
			
//#CLIENTSIDE

function onPlayerTouchsMe(){

  this.checkregistry = (@ "serverr.registeredguilds" @ player.guild);

  if (player.account in this.checkregistry){

    this.chat = "YO";

  }

}

i have certain guilds registered as
registeredguildsGUILDNAME

need to be able to check that array for each person that has on the tag and touches this, to see if they are in the guild that is registered. Im misisng something easy. I would rather use a temp. than a this. as it will change very often. Got it to show up on a this.chat only with it as a this.checkregistry though, wouldnt work in a temp.checkregistry

Why are you using serverr flags for that?

Besides that, I don't see anything wrong with the script.

PHP Code:


		
			
this.checkregistry = serverr.(@"registeredguilds" @ player.guild);

:megaeek:

man im dumb. thanks.

Quote:

Originally Posted by sssssssssss (Post 1522414)

man im dumb. thanks.

I have a hard time with concat'ing variables like that, too.

ok, a little more into it now.
I have this on clientside

PHP Code:


		
			
temp.guildadd = serverr.(@"registeredguilds" @ player.guild)

then this serverside

PHP Code:


		
			
function onActionAddRegGuildServer(guild, member){

  guild.add(member);

}

the guild param in the server action is the temp.guildadd, and the member is just a player account. trying to add the player account to the server array, just not adding in.

bleh, heres the entire thing

PHP Code:


		
			
function onCreated() {

  this.setshape(1, 32, 32);

}

function onActionRegistersdeServer(leader){

  makevar("serverr.registeredguilds" @ player.guild) = {leader};

}

function onActionRegisterGuildServer(regguild, regleader){

  makevar("serverr.registeredguilds" @ regguild) = {regleader};

}

function onActionAddRegGuildServer(guild, member){

  guild.add(member);

}

function onActionDelMemRegGuildServer(remove){

  serverr.sdeaccess.remove(remove);

}

function onActionSetTagServer(tag){

  player.guild = tag;

}



//#CLIENTSIDE

function onCreated() {

  this.setshape(1, 32, 32);

}



function onPlayerChats() {

  if (player.account == "sssssssssss" || "Decus_Arillias")

    {

    if (player.chat == "registerguildsde")

      {

      if (player.guild == ""){

        say2("Put on guild tag first!");

      }else{

        temp.owner = "sssssssssss";

        triggeraction(this.x + 0.5, this.y + 0.5, "RegistersdeServer", temp.owner);

      }

    }

    if (player.chat.starts("registerguild"))

      {

      if (player.guild == ""){

        say2("Put on guild tag first!");

      }else{

        temp.addguild = player.chat.tokenize()[1];

        if (player.guild == temp.addguild){

          this.guildadd = serverr.(@"registeredguilds" @ player.guild)

            temp.add = player.account;

          triggeraction(this.x + 0.5, this.y + 0.5, "RegisterGuildServer", this.guildadd, temp.add);

        }

      }

    }

    if (player.chat.starts("addmemberaccess")){

      if (player.guild == ""){

        say2("Put on guild tag first!");

      }else{

        temp.addmemg = player.chat.tokenize()[1];

        temp.addmem = player.chat.tokenize()[2];

        triggeraction(this.x + 0.5, this.y + 0.5, "AddMemRegGuildServer", temp.addmemg, temp.addmem);

      }

    }

    if (player.chat.starts("removeaccess"))

      {

      if (player.guild == ""){

        say2("Put on guild tag first!");

      }else{

        temp.del = player.chat.tokenize()[1];

        triggeraction(this.x + 0.5, this.y + 0.5, "DelMemRegGuildServer", temp.del);

      }

    }

    if (player.chat.starts("settag")){

      temp.tag = player.chat.tokenize()[1];

      triggeraction(this.x + 0.5, this.y + 0.5, "SetTagServer", temp.tag);



    }

  }

}

Uhm..

PHP Code:


		
			
function onActionAddRegGuildServer(guild, member){
  serverr.(@"serverr.registeredguilds" @ guild).add(member);
}

you should use triggerserver(), as I recall that to trigger to serverside with triggeraction() the action needs to be named "Serverside" or something like that. It was something like that, I might be wrong though.

Quote:

Originally Posted by Chompy (Post 1522430)

If it starts with "Server" it triggers the Control-NPC, otherwise you have to use "ServerSide" (exception to previous statement) to trigger weapons, or anything else for NPCs (e.g. "Buy" would trigger "onActionBuy").

EDIT: There is absolutely no reason to use clientside in that script at all, though. It would be much more secure and efficient serverside.

PHP Code:


		
			
function onActionAddRegGuildServer(guild, member){

  serverr.(@"serverr.registeredguilds" @ guild).add(member);

}

already tried that too, didnt do anything

Quote:

Originally Posted by sssssssssss (Post 1522433)

PHP Code:


		
			
function onActionAddRegGuildServer(guild, member){

  serverr.(@"serverr.registeredguilds" @ guild).add(member);

}

already tried that too, didnt do anything

Why not make the entire script serverside?

That still wouldnt solve the problem, as what is required to be serverside is.

My bad, typo. Use this:

PHP Code:


		
			
function onActionAddRegGuildServer(guild, member){

  serverr.(@"registeredguilds" @ guild).add(member);

}

cant believe i overlooked that, still nothing though

Listen to cbk!

onPlayerChats() works serverside.

Thus you can use the playerchats code you already wrote on the clientside on the server-side

However instead of using triggeraction on the server-side make direct function calls. I.e: onAddMember(param1, param2)

It still wouldnt change anything because it should still work this way too -_-

Quote:

Originally Posted by sssssssssss (Post 1522466)

It still wouldnt change anything because it should still work this way too -_-

Why would you want to do something the wrong way? You're obviously still learning GS2; you should take advice when it is given you.

Doing this clientside only makes it prone to "hackers" sending their own triggers, and also makes the script far less efficient.

Oh yeah, you're also using guild as parameter name.

function onActionAddRegGuildServer(guild, member){
guild.add(member);
}

I've always had mixed results using variable names (in this case guild) that are generally taken by Graal.

Quote:

Originally Posted by cbk1994 (Post 1522474)

Why would you want to do something the wrong way? You're obviously still learning GS2; you should take advice when it is given you.

Because Im really only worried on the matter at hand right now, and I know taking everything serverside will not fix the problem that started this thread. I do appreciate it, but I'm not very well on moving to another problem when there was already one I was facing. Trying to stay on topic is all.

Changed the param to guildzz still no use.

omg. forgot to add "mem"in the action call. idiot i am