Graal Forums - onwater2 not working

Graal Forums (https://forums.graalonline.com/forums/index.php)

- Bug Report (https://forums.graalonline.com/forums/forumdisplay.php?f=193)

- - onwater2 not working (https://forums.graalonline.com/forums/showthread.php?t=86498)

onwater2 not working

I have the following script running:

PHP Code:


		
			
  if (horsecheck == true) {
    wall[0] = onwater2(player.x+check[k][0][0],player.y+check[k][0][1],check[k][2][0],check[k][2][1]);
    wall[1] = onwater2(player.x+check[k][1][0],player.y+check[k][1][1],check[k][2][0],check[k][2][1]);
  } else {
    wall[0] = onwall2(player.x+check[k][0][0],player.y+check[k][0][1],check[k][2][0],check[k][2][1]);
    wall[1] = onwall2(player.x+check[k][1][0],player.y+check[k][1][1],check[k][2][0],check[k][2][1]);
  }

Basically, if the player is riding a horse it will check for water, and if not it will check for a wall.

They both use the exact same checks. With wall checking, the detection is perfect. However, if I start trying to detect water, half the time the player will go halfway into the body of water and such. It seems to have a slight delay in actually registering water.

This is clientside, by the way. Can this please be fixed? :(

edit: after some testing, onwater2(x,y,1,1) will only check a one pixel area for water, NOT 1 tile, like onwall2. HOWEVER, onwater2(x,y,2,2) functions the same as onwall2(x,y,1,1)... so I don't know what the hell is going on.

Here's in the script I used to test:

PHP Code:


		
			
  showpoly(200,{mousex-1,mousey,mousex-1+1,mousey,mousex-1+1,mousey+1,mousex-1,mousey+1});
  changeimgcolors(200,1,0,0,.25);
  showpoly(201,{mousex,mousey,mousex+1,mousey,mousex+1,mousey+1,mousex,mousey+1});
  changeimgcolors(201,0,1,0,.25);
  player.chat = onwater2(mousex-1,mousey,1,1) SPC onwall2(mousex,mousey,1,1);

http://i42.tinypic.com/261f9ly.png
Red box represents my water check, and the green is the wall check. Both are identical, except one returns true(the onwall2) and one does not -- these results are also shown over the player's head, left is the water check and right is the wall.

Does it work in the bigger areas?

Quote:

Originally Posted by Robin (Post 1502175)

Does it work in the bigger areas?

Don't know what you mean. All I know is it doesn't work like it should.

Stefan, could this be fixed please? I don't want to rewrite a WHOLE movement system to accommodate for a bug.

Quote:

Originally Posted by DustyPorViva (Post 1516693)

Don't know what you mean. All I know is it doesn't work like it should.

Stefan, could this be fixed please? I don't want to rewrite a WHOLE movement system to accommodate for a bug.

I've never trusted the onwall2 or onwater2 functions, but

For now anyway, maybe just use a solution like the following?

PHP Code:


		
			
function onwater3(tx, ty, w, h) {
  if (w == 1) w = 2;
  if (h == 1) h = 2;
  return onwater2(tx, ty, w, h);
}

Edit: I see that you might be using more than just 1 tile checks.

onwall2 is fine, you just have to be aware of Graal's polygon calculation bug, since onwall2 seems to use the same code. Not sure about onwater2 though, but I can't image why it wouldn't function properly. I will give it a go soon.

please fix! thank you