Graal Forums - if (GangTagSystem != Working) { //what do I do? }

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - if (GangTagSystem != Working) { //what do I do? } (https://forums.graalonline.com/forums/showthread.php?t=76655)

if (GangTagSystem != Working) { //what do I do? }

Name says it all. The script is here:

PHP Code:


		
			
function onActionServerSide() {

  with(findplayer(params[0])) {

    if (player.guild != clientr.gang) {

      player.nick = player.nick@ " *" @clientr.gangrank@ "* (" @clientr.gang@ ")";

    }

  }

}



//#CLIENTSIDE

function onPlayerChats() {

  if (player.chat == "/gang tag") {

    if (strlen(#s(clientr.gang > 0))) {

      triggerserver("weapon", this.name, player.account);

    }

  }

}

How can I get it working? It just sits there and does nothing. And yes, I DO have it (wep) in my attributes.

Also, if anything is in GS1, if you can can you please convert it to GS2?

if (strlen(#s(clientr.gang > 0))) {
can be changed to
if (clientr.gang > 0){
t does the same thing :P

Well try

PHP Code:


		
			
function onActionServerSide() {
  with(findplayer(params[0])) {
    if (player.guild != clientr.gang) {
      player.nick = player.nick @ " *" @clientr.gangrank@ "* (" @clientr.gang@ ")";
    }
  }
}

//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat == "/gang tag") {
    if (strlen(clientr.gang > 0)) {
      triggerserver("gui", "weapon", player.account);
    }
  }
}

Nope didn't work, Mike x_x

Quote:

Originally Posted by PrinceOfKenshin (Post 1346050)

Well try

PHP Code:


		
			
function onActionServerSide() {
  with(findplayer(params[0])) {
    if (player.guild != clientr.gang) {
      player.nick = player.nick @ " *" @clientr.gangrank@ "* (" @clientr.gang@ ")";
    }
  }
}

//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat == "/gang tag") {
    if (strlen(clientr.gang > 0)) {
      triggerserver("gui", "weapon", player.account);
    }
  }
}

God, mixing GS1 and GS2 makes me cringe. That script is wrong btw.

PHP Code:


		
			
function onActionServerSide() {
  if (player.guild != clientr.gang) {
    player.nick = player.nick @ " *" @clientr.gangrank@ "* (" @clientr.gang@ ")";
  }
}

//#CLIENTSIDE
function onPlayerChats() {
  if (player.chat == "/gang tag") {
    if (clientr.gang.length() > 0) {
      triggerserver("gui", this.name, null);
    }
  }
}

I would normally add a parameter for what the serverside part is doing as a security measure, but didn't want to confuse it.

Also, triggers preserve the calling player so you don't need to use the findplayer() on serverside unless you want to access a player that isn't yourself.

well strlen was in the commands.rtf for gs2 so i thought that was ok.

Why don't you just set the player's guild instead of doing all that with the nick? o_O

Quote:

Originally Posted by Kyranki (Post 1346060)

Why don't you just set the player's guild instead of doing all that with the nick? o_O

Guild Rank :noob:

Quote:

Originally Posted by PrinceOfKenshin (Post 1346058)

well strlen was in the commands.rtf for gs2 so i thought that was ok.

There is no commands.rtf for GS2, that was made for GS1 and random people added onto it, you need to read the Wiki.

Instead of:

NPC Code:
strlen(string)

Please use:

NPC Code:
string.length()

Like:

NPC Code:

clientr.gang.length() > 0

(Or you can just do clientr.gang != "")

Thanks, it works now :)

Also, why'd you make it a "gui" [triggerserver("[I]gui[I]",.);]? It's supposed to be a weapon :p

Because weaponNPCs are considered gui's.

Quote:

Originally Posted by DustyPorViva (Post 1346187)

Because weaponNPCs are considered gui's.

For some strange reason.

Oh really? When I changed "gui" to "weapon" it was the same =\

I've always used 'gui': it's shorter ^^

Quote:

Originally Posted by Switch (Post 1346207)

Oh really? When I changed "gui" to "weapon" it was the same =\

It doesn't make any difference.

Quote:

Originally Posted by Kyranki (Post 1346337)

It doesn't make any difference.

Ya think?

I kinda noticed it when I changed it :p