Graal Forums - Bomb & Bow

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - Bomb & Bow (https://forums.graalonline.com/forums/showthread.php?t=74897)

Does anyone have the default bomb and bow script, like the one used in classic?

cant you use the default ones or do want to see the script? I'm not sure hwo they do there bow probably just shootarrow and stuff here's how I would do bombs

PHP Code:


		
			
//#CLIENTSIDE
function onWeaponFired() { 
if (player.bombs > 0) { 
  setani("lay", NULL); 
  freezeplayer(0.2); 
if (isOnMap) { 
  temp.px = player.x - (64 * getMapX(player.level)) + 0.5 + vecx(player.dir)*2; 
  temp.py = player.y - (64 * getMapY(player.level)) + 0.5 + vecy(player.dir)*2; 
  putBomb(1, temp.px, temp.py); 
} 
else { 
  putbomb(1,player.x + vecx(player.dir)*2, player.y + 0.5 + vecy(player.dir)*2); 
} 
  player.bombs --; 
} 
}

Why do you have to do all that detection for the player if they're on the map?
Last time I checked player.x/y gave the coordinates relative to the player on the gmap.

if your in the top left level it does otherwise it doesnt

Hmmm, odd, I've never had that problem.

Quote:

Originally Posted by Angel_Light (Post 1322566)

cant you use the default ones or do want to see the script? I'm not sure hwo they do there bow probably just shootarrow and stuff here's how I would do bombs

PHP Code:


		
			
//#CLIENTSIDE

function onWeaponFired() { 

if (player.bombs > 0) { 

  setani("lay", NULL); 

  freezeplayer(0.2); 

if (isOnMap) { 

  temp.px = player.x - (64 * getMapX(player.level)) + 0.5 + vecx(player.dir)*2; 

  temp.py = player.y - (64 * getMapY(player.level)) + 0.5 + vecy(player.dir)*2; 

  putBomb(1, temp.px, temp.py); 

} 

else { 

  putbomb(1,player.x + vecx(player.dir)*2, player.y + 0.5 + vecy(player.dir)*2); 

} 

  player.bombs --; 

} 

}

Much shorter version:

PHP Code:


		
			
//#CLIENTSIDE

function onWeaponFired() {

  if (player.bombs <= 0) return; 

  setani("lay", "");

  freezeplayer(0.2);

  putBomb(1, player.x%64 + 0.5 + vecx(player.dir)*2, player.y%64 + 1 + vecy(player.dir)*2);

  player.bombs --; 

}

Good use of math reduces the need to use if checks.
And why did you have + 0 on the Y for the map and + 0 on the x and + 0.5 for the Y off a map?