Graal Forums - Mini Lotto

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - Mini Lotto (https://forums.graalonline.com/forums/showthread.php?t=65490)

I'm making a mini lotto game for DR. The script works for 1 NPC, but put more than one in a level, and ALL of them trigger the test action. Why??

PHP Code:


		
			


// NPC made by Excaliber

function onCreated()

{

  setshape(1,32,32);

}

function onActiontest()

{

  playerrupees-=1;

  this.minilotto_num1=int(random(0,9));

  this.minilotto_num2=int(random(0,9));

  this.minilotto_num1*=10;

  this.minilotto_num=this.minilotto_num1+this.minilotto_num2;

  if(client.minilotto_num==this.minilotto_num)

  {

    chat="JACKPOT!";

    with(findplayer(player.account))

    {

      play extra.wav; //doesn't work

      playerrupees+=51; //does work

    }

  }

  else

  {

    chat="Nothing this time... Last number: "@this.minilotto_num;

  }

}

//#CLIENTSIDE

function onPlayertouchsme()

{

  if(playerrupees>0)

  {

    chat="Playing";

    client.minilotto_num=0;

    mini_lotto.showtop();

    new GuiWindowCtrl("mini_lotto")

    {

      //gui window stuff



        new GuiButtonCtrl("roll")

        {

          //roll button stuff

        }

        new GuiTextEditCtrl("p1num")

        {

         //text stuff

        }

      new GuiTextEditCtrl("p2num")

        {

          //text stuff

        }

      }

    }

  }

  function roll.onAction()

  {

    //var setup

    triggeraction(x,y,"test","test");

  }

GUI control names are shared across NPCs. Likely, each NPC is receiving roll.onAction().

also, I believe play only works clientside
also it would be play(file);

Yeah, the GUI control names are probably conflicting with eachother. Try using something like "roll_" @ this.id or whatever.

also, findplayer(player.account) is the most redundant function call in GraalScript x_x

Quote:

Originally Posted by ApothiX

After all, player == findplayer(player.account) is a tautology.

I really can't express how much I want with statements to be deprecated.

Quote:

Originally Posted by jake13jake

I really can't express how much I want with statements to be deprecated.

'with()' lets you modify multiple aspects of a foreign object, without having to repeat the object reference.

PHP Code:


		
			
with (findimg(300)) {

  x = 30;

  y = 30;

  text = "Hi!";

  font = "Times New Roman";

  style = "cb";

  red = 1;

  green = 0;

  blue = 1;

}

Quote:

Originally Posted by Yen

'with()' lets you modify multiple aspects of a foreign object, without having to repeat the object reference.

Yes, I know, but I prefer using the object reference.