Graal Forums - Health bar

Graal Forums (https://forums.graalonline.com/forums/index.php)

- NPC Scripting (https://forums.graalonline.com/forums/forumdisplay.php?f=8)

- - Health bar (https://forums.graalonline.com/forums/showthread.php?t=134264954)

callimuc

11-03-2011 02:25 AM

Health bar

Well I´m trying to make a health bar in a gani. I was looking around the forums for help and my result was this:

PHP Code:


		
			
SCRIPT

function onPlayerEnters() {

  hideimgs(200, 3000);

  temp.pl = findplayer(player.account);

  with (findimg(200)) {

    x = player.x + 2/16;

    y = player.y - 1.75;

    image = "pirate_healthbar.png";

    width = maxWidth;

    height = maxHeight;

    attachtoowner = true;

  }

  with (findimg(201+pl.id)) {

    x = player.x + 10/16;

    y = player.y - 1.75 + 3/16;

    image = "pirate_healthbar-progress.png";

    width = getimgwidth(image);

    height = getimgheight(image);

    attachtoowner = true;

  }

  part=(pl.clientr.health_hearts/pl.clientr.health_fullhearts)*findimg(201+pl.id).width;

  changeimgpart(201+pl.id, findimg(201+pl.id).width-part, 0, part, findimg(201+pl.id).height); 

}

SCRIPTEND

I know it´s not updating constantly but thats not my problem. My problem is that it shows the clients hp in the correct form. But the bar at the other players keeps saying that the player has 100% health even when it´s not true.

How can I fix it?

ffcmike

11-03-2011 02:35 AM

Quote:

Originally Posted by callimuc (Post 1672829)

Well I´m trying to make a health bar in a gani. I was looking around the forums for help and my result was this:

PHP Code:


		
			
SCRIPT
function onPlayerEnters() {
  hideimgs(200, 3000);
  temp.pl = findplayer(player.account);
  with (findimg(200)) {
    x = player.x + 2/16;
    y = player.y - 1.75;
    image = "pirate_healthbar.png";
    width = maxWidth;
    height = maxHeight;
    attachtoowner = true;
  }
  with (findimg(201+pl.id)) {
    x = player.x + 10/16;
    y = player.y - 1.75 + 3/16;
    image = "pirate_healthbar-progress.png";
    width = getimgwidth(image);
    height = getimgheight(image);
    attachtoowner = true;
  }
  part=(pl.clientr.health_hearts/pl.clientr.health_fullhearts)*findimg(201+pl.id).width;
  changeimgpart(201+pl.id, findimg(201+pl.id).width-part, 0, part, findimg(201+pl.id).height); 
}
SCRIPTEND

There are atleast 2 key problems here.

First, you cannot read clientr. variables of other players on your own client. This is where health would need to be stored as part of an attribute.
So essentially this is attempting to show a bar with 0 width, which actually shows the entire bar and makes it look as if it's 100% full.

The second problem is that even if you had HP working properly you don't seem to have a mechanism for updating the display upon HP being changed, unless you're just re-initialising the gani as part of the attribute upon players being damaged?

On a side note it is pointless to be doing pl = findplayer(player.account); as you already have the player object. You also do not need to be referring to pl.id as part of the display index as these displays are on the gani attribute of each player and cannot collide. This also means you do not need to be doing hideimgs(200, 3000); .

fowlplay4

11-03-2011 02:41 AM

Try reading this thread:
http://forums.graalonline.com/forums...hp?t=134264542

I made a post in there that should help you out.

callimuc

11-03-2011 02:41 AM

Quote:

Originally Posted by ffcmike (Post 1672833)

First, you cannot read clientr. variables of other players on your own client. This is where health would need to be stored as part of an attribute.
So essentially this is attempting to show a bar with 0 width, which actually shows the entire bar and makes it look as if it's 100% full.

Oh thanks.

Quote:

Originally Posted by ffcmike (Post 1672833)

The second problem is that even if you had HP working properly you don't seem to have a mechanism for updating the display upon HP being changed, unless you're just re-initialising the gani as part of the attribute upon players being damaged?

Already said that I knew that and wanted to fix the other thing at first . But I wanted to have it shown up as soon as the player was damaged.

callimuc

11-03-2011 04:23 AM

Quote:

Originally Posted by fowlplay4 (Post 1672837)

Try reading this thread:
http://forums.graalonline.com/forums...hp?t=134264542

I made a post in there that should help you out.

Jea I took a look at tit and while testing it it seems like I did something wrong cause now I tried it and it worked ^^

Well what is better to use: A gani scripted one or in a waepon? Like it´s said above it should only pop up for a time when the player is being damaged.

fowlplay4

11-03-2011 04:51 AM

Depending on how your damage is handled you could just do something like this with showani and scheduleevent.

PHP Code:


		
			
//#CLIENTSIDE

function onDamage(amount) {

  showani(100, player.x, player.y, 0, "your_damage_gani", hp_ratio);

  this.scheduleevent(2, "HideDamage", "");

}



function onHideDamage() {

  hideimg(100);

}

You'll be able to use params[0]/hp_ratio to determine how much of the bar you'll need to show.

callimuc

11-03-2011 04:57 AM

Well I´m adding the gani to the players attributes whenever the player is hit (also changes the health than). And I made something like this in the gani

PHP Code:


		
			
SCRIPT
function onPlayerEnters() {
  hideimgs(200, 201);
  temp.pl = findplayer(player.account);
  with (findimg(200)) {
    x = player.x + 2/16;
    y = player.y - 1.75;
    image = "pirate_healthbar.png";
    width = maxWidth;
    height = maxHeight;
    attachtoowner = true;
  }
  with (findimg(201)) {
    x = player.x + 10/16;
    y = player.y - 1.75 + 3/16;
    image = "pirate_healthbar-progress.png";
    width = getimgwidth(image);
    height = getimgheight(image);
    attachtoowner = true;
  }
  part=(pl.attr[28]/pl.attr[29])*findimg(201).width;
  changeimgpart(201, findimg(201).width-part, 0, part, findimg(201).height); 
  settimer(3);
}

function onTimeOut() {
  for (temp.i = 1; temp.i => 0; temp.i -= 0.01) {
    changeimgcolors(200, i, i, i, i);
    changeimgcolors(201, i, i, i, i);
    sleep(0.05);
  }
  if (findimg(200).alpha == 0 || findimg(201).alpha == 0) player.attr[2] = "";
}
SCRIPTEND

fowlplay4

11-03-2011 05:00 AM

Quote:

Originally Posted by callimuc (Post 1672879)

Well I´m adding the gani to the players attributes whenever the player is hit (also changes the health than). And I made something like this in the gani

I don't think you can edit attrs in ganis. Just take the code I posted above and set an attr and unset it instead of using showani/hideimg.

callimuc

11-03-2011 05:09 AM

Quote:

Originally Posted by fowlplay4 (Post 1672880)

I don't think you can edit attrs in ganis. Just take the code I posted above and set an attr and unset it instead of using showani/hideimg.

Well it worked for me. In an other script I had player.chat = player.attr[2]; and everything was fine. But I´ll try out your method.

callimuc

11-03-2011 07:38 PM

Quote:

Originally Posted by fowlplay4 (Post 1672837)

Try reading this thread:
http://forums.graalonline.com/forums...hp?t=134264542

I made a post in there that should help you out.

I was testing out the site fp4 suggested and wasn´t sure how I should draw 2 images (since my health bar is out of 2 images).

Should I just start the 2nd image starting with an index of like 3000 or what?

fowlplay4

11-03-2011 08:06 PM

This also works:

PHP Code:


		
			
temp.i = 0;

for (temp.p: players) {

  with (findimg(200 + temp.i)) {

    // BAR

  }

  with (findimg(200 + 1 + temp.i)) {

    // BAR CONTENTS

  }

  temp.i += 2;

}

callimuc

11-03-2011 09:26 PM

Ahh didnt think of that ^^

callimuc

11-04-2011 01:41 AM

Well I played around with that and got this:

PHP Code:


		
			
//#CLIENTSIDE
function onCreated() {
  settimer(0.05);
}

function onPlayerEnters() {
  this.lastsize = 0;
  settimer(0.05);
}

function onTimeout() {
  if (players.size() != this.lastsize) {
    drawInfo();
    this.lastsize = players.size();
  }
  else updateInfo();
  setTimer(0.05);
}

function drawInfo() {
  temp.i = 0;
  this.drawing1 = {};
  this.drawing2 = {};
  hideimgs(200, 3000);
  for (temp.p: players) {
    with (findimg(200 + temp.i)) {
      x = p.x + 2/16;
      y = p.y - 1.75;
      width = getimgwidth(image);
      height = getimgheight(image);
      image = "pirate_healthbar.png";
    }
    with (findimg(200 + 1 + temp.i)) {
      x = findimg(200 + temp.i).x + 8/16;
      y = findimg(200 + temp.i).y + 3/16;
      width = getimgwidth(image);
      height = getimgheight(image);
      image = "pirate_healthbar-progress.png";
    }
    this.drawing1.add({temp.p, 200 + i});
    this.drawing2.add({temp.p, 200 + 1 + temp.i});
    part=(p.attr[28]/temp.p.attr[29])*findimg(this.drawing2[1]).width;
    changeimgpart(this.drawing2[1], findimg(this.drawing2[1]).width-part, 0, part, findimg(this.drawing2[1]).height);
  }
  temp.i += 2;
}

function updateInfo() {
  for (temp.p: players) {
    with (findimg(this.drawing1[1])) {
      x = p.x + 2/16;
      y = p.y - 1.75;
    }
    with (findimg(this.drawing2[1])) {
      x = findimg(200 + temp.i).x + 8/16;
      y = findimg(200 + temp.i).y + 3/16;
    }
    part = (p.attr[28]/temp.p.attr[29])*findimg(this.drawing2[1]).width;
    changeimgpart(this.drawing2[1], findimg(this.drawing2[1]).width-part, 0, part, findimg(this.drawing2[1]).height);
  }
}

My problem is that it won´t update the progress and it´s only shown on one player.
How can I fix that?

Gunderak

11-04-2011 02:01 AM

Maybe increase an index variable, say for instance.

PHP Code:


		
			
for(temp.ind : players){
temp.indx = ind.account.substring(1);
with(findimg(200) + i + temp.indx){

Im not sure of something like that would work but idk.
The problem is your using one image to display everyones health, I think you need some sort of index so that you can show dynamic text.

fowlplay4

11-04-2011 04:11 AM

You're looping through each player and only using the element 1 in the array. I believe there was an error in my code unfortunately I can't go back and edit it now.

In your drawing function record the following in an array:

this.drawing.add({temp.p, 200 + temp.i});

In your updating function loop through your drawing array:

PHP Code:


		
			
for (temp.draw: this.drawing) {

  temp.plyr = temp.draw[0];

  temp.img_index = temp.draw[1];

  with (findimg(temp.img_index)) {

    // Update position

    x = temp.plyr.x;

    y = temp.plyr.y;

  }

  with (findimg(temp.img_index + 1)) {

    // Update position

  }

}

Also just some small optimizations/changes you can make as well:

1. Store the width and height of your bar graphics in a variable outside the loop. Calling getimgwidth and getimgheight repeatedly isn't needed.
2. Use partx, party, partw, and parth instead of changeimgpart since you're already using findimg in a with statement.

PHP Code:


		
			
// Using part in findimg assignments

with (findimg(200)) {

  image = "head0.png";

  partx = 0;

  party = (32 * 2);

  partw = 32;

  parth = 32;

}

// Same thing as doing:

changeimgpart(200, 0, 32 * 2, 32, 32);

3. Be more consistent when using temp. In the same line you use it with and without the prefix. Avoid setting global variables (your line part=math+blah;) that don't need to be global. You can do that by putting temp. I.e: temp.part.

All times are GMT +2. The time now is 07:53 AM.