Graal Forums

Graal Forums (https://forums.graalonline.com/forums/index.php)
-   PlayerWorlds Main Forum (https://forums.graalonline.com/forums/forumdisplay.php?f=15)
-   -   Empty PMs linked to hacking incident. (https://forums.graalonline.com/forums/showthread.php?t=134266472)

DustyPorViva 05-21-2012 07:31 PM

Quote:

Originally Posted by fowlplay4 (Post 1695215)
It's not that simple, you can log image requests in general. I.e. In Rails:

Started GET "/test_fowlplay4.png" for 127.0.0.1 at 2012-05-21 09:43:46 -0700

I still think the best option will be a white-list of approved image hosts, and then an player-list option to disable the rendering of external images in PMs.

Unless Stefan can script it into the PM system we'll likely need a client update (we're way overdue already).

Not familiar with the wordfilter, so I'll use regex, but would something like this be possible for now?

RULE
CHECK pm
MATCH {php|png|jpg|jpeg|gif}\?.\>
PRECISION 100%
WORDPOSITION part
ACTION log replace
RULEEND

Be possible?

Hiro 05-21-2012 08:05 PM

Yea we totally need images and HTML in mass messages and PMs instead of taking care of a blatant security risk.

The **** is wrong with you people? Just remove them altogether.

bloodykiller 05-21-2012 09:39 PM

images are really useful on era since there are hundreds of different hats and most people don't know what they all look like..i know of people who massed perverted images/videos and i also know by fact that they were banned and reset so people don't really do that anymore xD
a viable option would be to disable clicking on the images, allowing players to simply view them

Emera 05-21-2012 09:44 PM

Quote:

Originally Posted by bloodykiller (Post 1695234)
images are really useful on era since there are hundreds of different hats and most people don't know what they all look like..i know of people who massed perverted images/videos and i also know by fact that they were banned and reset so people don't really do that anymore xD
a viable option would be to disable clicking on the images, allowing players to simply view them

X_X Viewing the images is what causes the issue, bloodykiller.

bloodykiller 05-21-2012 09:56 PM

u should be able to take images off it u wanted to, but why should graal regress like this? images were used by a lot of players

Hezzy002 05-21-2012 10:21 PM

Yay, everyone ignores my solution that can totally be scripted in!

DustyPorViva 05-21-2012 10:31 PM

Quote:

Originally Posted by Hezzy002 (Post 1695238)
Yay, everyone ignores my solution that can totally be scripted in!

I don't imagine the servers can take the extra stress of being an image host as well.

cbk1994 05-21-2012 10:35 PM

Quote:

Originally Posted by Hezzy002 (Post 1695238)
Yay, everyone ignores my solution that can totally be scripted in!

It can't be scripted in except with login scripts.

fowlplay4 05-21-2012 10:39 PM

Quote:

Originally Posted by DustyPorViva (Post 1695239)
I don't imagine the servers can take the extra stress of being an image host as well.

They certainly could but to me it's more why waste the bandwidth?

Hiro 05-21-2012 11:06 PM

Quote:

Originally Posted by bloodykiller (Post 1695237)
u should be able to take images off it u wanted to, but why should graal regress like this? images were used by a lot of players

And then everyone in their right mind disables them as to not be exploited.

Hezzy002 05-21-2012 11:09 PM

Quote:

Originally Posted by cbk1994 (Post 1695240)
It can't be scripted in except with login scripts.

It was in response to FP4's "Unless Stefan can script it into the PM system..."

And the servers can totally take the stress of being an image host, it's practically nothing compared to all the other images/ganis/bytecode/levels it serves, especially because of their infrequent use.

And why "waste" the bandwidth? Well, because it's a solution that works and doesn't restrict the users.

nightslayer317 05-22-2012 12:09 AM

Quote:

Originally Posted by Hiro (Post 1695224)
Yea we totally need images and HTML in mass messages and PMs instead of taking care of a blatant security risk.

The **** is wrong with you people? Just remove them altogether.

^^^

Fulg0reSama 05-22-2012 10:15 AM

Only If there was like an approval system for any masses with <img> tags :(

Too bad that's also very inefficient.

cbk1994 05-22-2012 05:04 PM

Quote:

Originally Posted by DustyPorViva (Post 1695220)
Not familiar with the wordfilter, so I'll use regex, but would something like this be possible for now?

RULE
CHECK pm
MATCH {php|png|jpg|jpeg|gif}\?.\>
PRECISION 100%
WORDPOSITION part
ACTION log replace
RULEEND

Be possible?

What are you trying to accomplish? The extension is unimportant. Only the Content-Type header matters. Even without a proper image content-type header, the browser is still going to try to load it, and I still get your IP. The best solution to disable images is Jer's:

Quote:

Originally Posted by fowlplay4 (Post 1694957)
Append to wordfilter/rules.txt

PHP Code:

RULE
CHECK pm
MATCH 
<img
PRECISION 100
%
WORDPOSITION part
ACTION replace
RULEEND 


As far as I know, the wordfilter rules aren't advanced enough to allow certain text to be exempted (to create a whitelist). This would have to be done with login scripts or by Stefan.

scriptless 12-06-2012 03:30 AM

It's not just images.. Basically what they are doing is using an image, or any other file.. on ther website so that when you open a PM and it loads the file from there server.. they have our IP address and becasue of #a they have your account name.. they can match who is who..

you can safely do a read history before you open your pm's if your seriously paranoid about it.. images just happen to be the easiest way to accomplish it.

I think personally, it should be hard coded into graal to only allow images from the server your on because it helps people when selling items to show what they look like.


Someone correct me if I am wrong, but isn't it possible in GS2 to check pm's? I thought GK has a swear filter for that.. and if it is possible, a script could simply phrase for "<img" and warn user that a potential harm may be detected..?

cbk1994 12-06-2012 09:23 AM

Quote:

Originally Posted by scriptless (Post 1708675)
Someone correct me if I am wrong, but isn't it possible in GS2 to check pm's? I thought GK has a swear filter for that.. and if it is possible, a script could simply phrase for "<img" and warn user that a potential harm may be detected..?

Kingdoms uses the standard swearfilter to filter PMs. I don't think it's possible for scripts to view/modify PMs (for good reason, too). Privileged (login) scripts may be able to, but I don't think so. PMs are displayed using special GUI controls (not just standard GuiMLTextCtrls) which prohibit accessing or changing the displayed message.


All times are GMT +2. The time now is 12:06 PM.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2026, vBulletin Solutions Inc.
Copyright (C) 1998-2019 Toonslab All Rights Reserved.